VSCode: Move Scarb searching logic to the Scarb class

[mkaput]

Stack:

• VSCode: Move isScarbProject logic to separate file #5015
• VSCode: Slightly simplify LS selection logic #5014
• VSCode: Extract standalone CairoLS logic to StandaloneLS class #5013
• VSCode: Move Scarb searching logic to the Scarb class #5012 ⬅
• VSCode: Encapsulate all configuration magic into Config class #4976
• VSCode: Move away and simplify tool finding functions #4975
• VSCode: Add Scarb class and move Scarb's LS discovery there #4974
• VSCode: Do not spawn LS process manually and use VSC idioms instead #4973

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[Arcticae]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mkaput and @orizi)

---

vscode-cairo/src/cairols.ts line 200 at r1 (raw file):

      scarb = await Scarb.find(workspaceFolder, ctx);
    } catch (e) {
      ctx.log.error(`${e}`);

obsolete interpolation

---

vscode-cairo/src/scarb.ts line 34 at r1 (raw file):

    async function findPath(): Promise<string> {
      // TODO(mkaput): Config should probably be scoped to workspace folder.
      // Check config for scarb path.

I'd use 3 functions instead of those comments and do return fromConfig() || fromPath() || fromEnv()

[mkaput]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae and @orizi)

---

vscode-cairo/src/cairols.ts line 200 at r1 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

obsolete interpolation

This is the only way I know to make TypeScript happy. ctx.log.error(msg: string), while e: unknown, so I cannot call .toString()

[mkaput]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae and @orizi)

---

vscode-cairo/src/scarb.ts line 34 at r1 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

I'd use 3 functions instead of those comments and do return fromConfig() || fromPath() || fromEnv()

Done.

[Arcticae]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)

[orizi]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)