Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode: Refactor cairols.ts to use Context and levelled logging #4959

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

@mkaput mkaput requested a review from orizi February 6, 2024 10:30
vscode-cairo/src/cairols.ts Show resolved Hide resolved
vscode-cairo/src/cairols.ts Show resolved Hide resolved
Copy link
Contributor Author

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @Arcticae and @orizi)


vscode-cairo/src/cairols.ts line 31 at r1 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

Isn't this more like a context function since it uses it?

It kinda is, but I would rather not touch this code in this PR. In #5013 this function is removed entirely.


vscode-cairo/src/cairols.ts line 146 at r1 (raw file):

Previously, Arcticae (Tomasz Rejowski) wrote…

Does this show up in 2 different places?

Yes, the warning is an alert in UI, while ctx.log.error outputs a line in Output > Cairo Extension panel.

Copy link
Collaborator

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@mkaput
Copy link
Contributor Author

mkaput commented Feb 8, 2024

Closing pull request: commit has gone away

@mkaput mkaput closed this Feb 8, 2024
@mkaput mkaput reopened this Feb 8, 2024
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@mkaput mkaput added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 504f718 Feb 12, 2024
44 checks passed
@mkaput mkaput deleted the spr/main/94f4795c branch February 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants