-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode: Refactor cairols.ts to use Context
and levelled logging
#4959
Conversation
c79e174
to
d7177a3
Compare
0ee3781
to
136f3e6
Compare
d7177a3
to
f86fd38
Compare
136f3e6
to
b89d144
Compare
b89d144
to
a47e4b5
Compare
f86fd38
to
0ff66be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @Arcticae and @orizi)
vscode-cairo/src/cairols.ts
line 31 at r1 (raw file):
Previously, Arcticae (Tomasz Rejowski) wrote…
Isn't this more like a context function since it uses it?
It kinda is, but I would rather not touch this code in this PR. In #5013 this function is removed entirely.
vscode-cairo/src/cairols.ts
line 146 at r1 (raw file):
Previously, Arcticae (Tomasz Rejowski) wrote…
Does this show up in 2 different places?
Yes, the warning is an alert in UI, while ctx.log.error
outputs a line in Output > Cairo Extension
panel.
0ff66be
to
62068b2
Compare
a47e4b5
to
02262a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)
02262a9
to
2c1d181
Compare
62068b2
to
143ecaf
Compare
Closing pull request: commit has gone away |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
2c1d181
to
2801068
Compare
143ecaf
to
082e239
Compare
2801068
to
e5d1734
Compare
082e239
to
7e21349
Compare
commit-id:94f4795c
7e21349
to
087af3b
Compare
Stack:
isScarbProject
logic to separate file #5015StandaloneLS
class #5013Scarb
class #5012onEnterRules
#5011Config
class #4976Scarb
class and move Scarb's LS discovery there #4974Context
and levelled logging #4959 ⬅Context
class #4934This change is