-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode: Separate "main" functions from LanguageClient code #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2024
mkaput
force-pushed
the
spr/main/13cfed95
branch
2 times, most recently
from
January 30, 2024 19:48
9df0b69
to
0159f55
Compare
mkaput
force-pushed
the
spr/main/13cfed95
branch
from
February 1, 2024 11:58
0159f55
to
9a281b3
Compare
This was referenced Feb 1, 2024
mkaput
force-pushed
the
spr/main/13cfed95
branch
from
February 6, 2024 10:29
9a281b3
to
5c3a5cf
Compare
This was referenced Feb 6, 2024
mkaput
force-pushed
the
spr/main/13cfed95
branch
from
February 6, 2024 15:26
5c3a5cf
to
055f83c
Compare
This was referenced Feb 6, 2024
Arcticae
approved these changes
Feb 7, 2024
commit-id:13cfed95
mkaput
force-pushed
the
spr/main/13cfed95
branch
from
February 7, 2024 20:32
055f83c
to
c8492d2
Compare
orizi
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
tracing
instead oflog
#5021isScarbProject
logic to separate file #5015StandaloneLS
class #5013Scarb
class #5012onEnterRules
#5011Config
class #4976Scarb
class and move Scarb's LS discovery there #4974Context
and levelled logging #4959Context
class #4934This change is