-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode: Add Scarb
class and move Scarb's LS discovery there
#4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2024
mkaput
force-pushed
the
spr/main/74dcbc57
branch
from
February 6, 2024 10:29
c8b8058
to
f0d0058
Compare
mkaput
force-pushed
the
spr/main/67d23268
branch
from
February 6, 2024 10:29
4e2cf4c
to
69e3907
Compare
This was referenced Feb 6, 2024
mkaput
force-pushed
the
spr/main/67d23268
branch
from
February 6, 2024 15:26
69e3907
to
adedb76
Compare
mkaput
force-pushed
the
spr/main/74dcbc57
branch
from
February 6, 2024 15:26
f0d0058
to
4fdeba1
Compare
This was referenced Feb 6, 2024
mkaput
force-pushed
the
spr/main/67d23268
branch
from
February 7, 2024 20:32
adedb76
to
d00dd67
Compare
mkaput
force-pushed
the
spr/main/74dcbc57
branch
from
February 7, 2024 20:32
4fdeba1
to
04c0b51
Compare
mkaput
force-pushed
the
spr/main/67d23268
branch
from
February 8, 2024 10:37
d00dd67
to
b868a42
Compare
mkaput
force-pushed
the
spr/main/74dcbc57
branch
from
February 8, 2024 10:37
04c0b51
to
b55e82d
Compare
Closing pull request: commit has gone away |
mkaput
force-pushed
the
spr/main/67d23268
branch
from
February 12, 2024 06:36
b868a42
to
826f2e0
Compare
mkaput
force-pushed
the
spr/main/74dcbc57
branch
2 times, most recently
from
February 12, 2024 07:12
61d5d57
to
efaefc4
Compare
mkaput
force-pushed
the
spr/main/67d23268
branch
2 times, most recently
from
February 12, 2024 07:27
f398c41
to
aa2d300
Compare
mkaput
force-pushed
the
spr/main/74dcbc57
branch
from
February 12, 2024 07:27
efaefc4
to
103faa2
Compare
mkaput
force-pushed
the
spr/main/67d23268
branch
from
February 12, 2024 07:58
aa2d300
to
07e8fed
Compare
mkaput
force-pushed
the
spr/main/74dcbc57
branch
from
February 12, 2024 07:58
103faa2
to
304eb9c
Compare
orizi
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
commit-id:67d23268
mkaput
force-pushed
the
spr/main/67d23268
branch
from
February 12, 2024 10:07
07e8fed
to
81732f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
isScarbProject
logic to separate file #5015StandaloneLS
class #5013Scarb
class #5012Config
class #4976Scarb
class and move Scarb's LS discovery there #4974 ⬅This change is