Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode: Add Scarb class and move Scarb's LS discovery there #4974

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

@mkaput mkaput requested a review from orizi February 6, 2024 10:30
@mkaput
Copy link
Contributor Author

mkaput commented Feb 8, 2024

Closing pull request: commit has gone away

@mkaput mkaput closed this Feb 8, 2024
@mkaput mkaput reopened this Feb 8, 2024
@mkaput mkaput force-pushed the spr/main/74dcbc57 branch 2 times, most recently from 61d5d57 to efaefc4 Compare February 12, 2024 07:12
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

Base automatically changed from spr/main/74dcbc57 to main February 12, 2024 10:04
@mkaput mkaput added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 088fad1 Feb 12, 2024
44 checks passed
@mkaput mkaput deleted the spr/main/67d23268 branch February 12, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants