Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LS: Move all LS startup logic to its library main function #5019

Closed
wants to merge 14 commits into from
Closed

LS: Move all LS startup logic to its library main function #5019

wants to merge 14 commits into from

Commits on Feb 7, 2024

  1. VSCode: Separate "main" functions from LanguageClient code 

    commit-id:13cfed95
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c8492d2 View commit details
    Browse the repository at this point in the history

  2. VSCode: Create Context class 

    commit-id:78e7cc46
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d7faf1a View commit details
    Browse the repository at this point in the history

  3. VSCode: Use log output channel 

    commit-id:9d6c145d
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    02262a9 View commit details
    Browse the repository at this point in the history

  4. VSCode: Refactor cairols.ts to use Context and levelled logging 

    commit-id:94f4795c
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    62068b2 View commit details
    Browse the repository at this point in the history

  5. VSCode: Do not spawn LS process manually and use VSC idioms instead 

    This change removes the logic which passes CairoLS stdout to extension's
 logs. While this seems like a drawback, this logic was actually pretty
 unidiomatic and required early branching in LS binary searching code.
 CairoLS logs were printed by VSCode anyway in separate log channel.
 This code will be cleaned up further in subsequent commits.

commit-id:74dcbc57
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    04c0b51 View commit details
    Browse the repository at this point in the history

  6. VSCode: Add Scarb class and move Scarb's LS discovery there 

    commit-id:67d23268
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d00dd67 View commit details
    Browse the repository at this point in the history

  7. VSCode: Move away and simplify tool finding functions 

    commit-id:fd8af7de
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    43558de View commit details
    Browse the repository at this point in the history

  8. VSCode: Encapsulate all configuration magic into Config class 

    This commit also slightly changes the logic behind the
`${workspaceFolder}` placeholder. Now, it expands to empty string in
case there is no open workspace. This should not be a problem, because
it does not make sense to use this placeholder in global config.

commit-id:a58e04a6
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f148354 View commit details
    Browse the repository at this point in the history

  9. VSCode: Add several handy onEnterRules 

    commit-id:5ffc097f
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1e11c58 View commit details
    Browse the repository at this point in the history

  10. VSCode: Move Scarb searching logic to the Scarb class 

    commit-id:c0872618
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c174370 View commit details
    Browse the repository at this point in the history

  11. VSCode: Extract standalone CairoLS logic to StandaloneLS class 

    commit-id:43ff3b1c
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    efae254 View commit details
    Browse the repository at this point in the history

  12. VSCode: Slightly simplify LS selection logic 

    commit-id:30ace537
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    855e667 View commit details
    Browse the repository at this point in the history

  13. VSCode: Move isScarbProject logic to separate file 

    commit-id:f5c8f336
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    038f67a View commit details
    Browse the repository at this point in the history

  14. LS: Move all LS startup logic to its library main function 

    This change gives the LS crate exclusive control on its running
environment and behaviours, like Tokio runtime or logging.

commit-id:548527aa
    @mkaput
    mkaput committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c1bb4e0 View commit details
    Browse the repository at this point in the history