fix: use "ams" quota type in e2e tests #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove targeted cluster placement strategy. * Fix the FirstReadyPlacementStrategy to be a pointer
* add migration for default version table * implemented central default version api endpoints * allow POST method for full admins * set current version as default version for migration * ROX-12188: api target central version (#907)
…gic (#904) * Remove skip scheduling. * Add migration to delete the SkipScheduling column. * Remove final references to skip scheduling. Replace with use of schedulable. * Remove SkipScheduling, add Schedulable to cluster API and table columns * Tests * Fixed tests for placement. Removed supported instance type from cluster search API. * Fix migration * Fix migration ID * Remove unnecessary columns in migrations, per @machi1990's review comments. * Fix typo * Update moq file * Fix unit test * Fixes * Remove gorm default value from Schedulable. No columns use default values and, while 'false' may be surprising, the default value should never be used (aside from when this change is initially rolled out until the first reconciliation of the data plane config in saas.yaml is merged). * Update Schedulable field in database if the field's value changes in the dataplane config * Use values map to convince Gorm to update * Update moq --------- Co-authored-by: Vlad Bologa <[email protected]> Co-authored-by: Manyanda Chitimbo <[email protected]>
* Pass the region from the parameter store to the fleetshard sync * Update terraform_cluster.sh Use the parameter under the name CLUSTER_REGION, as it is stored with the cluster's parameters, not a "region" parameter group for the fleetshard sync
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.9.1 to 2.9.2. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.9.1...v2.9.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/golang/glog](https://github.com/golang/glog) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/golang/glog/releases) - [Commits](golang/glog@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: github.com/golang/glog dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.14.5 to 0.14.6. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.14.5...v0.14.6) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.27.3 to 1.27.6. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.27.3...v1.27.6) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* import rpm gpg key for CentOS * Update .openshift-ci/e2e-runtime/Dockerfile Co-authored-by: Yury Kovalev <[email protected]> --------- Co-authored-by: Yury Kovalev <[email protected]>
* Add ACS Operator installation * Drop test chart * Tune operator chart * Adopt upgrade tests * Review comments * Review comments * drop configmap * Add TODOs
* use HEAD as tag for fleetshard-sync image * use rev-parse
* ROX-16317: Extract a reusable data plane deployment workflow. Also add github action files linter while at it. * Fix path, hopefully. * Fix issues found by linter! * Do not complain on environments with a single cluster * pass secrets from environment definition * replace lint action with precommit * Add actionlint pre-commit hook (#927) --------- Co-authored-by: Yury Kovalev <[email protected]>
chore: upgraded app-services-sdk-go to Core SDK
…926) Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.325 to 0.1.331. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.325...v0.1.331) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ROX-13747: Run deploy workflow in dry-run mode as a PR check. * inherit secrets * Add support for dev env. * correct dev cluster name * Run "helm lint" rather than "helm upgrade --dry-run" in dev as there is no cluster. * same helm treatment for probe * missing import
…incompatible (#936) Bump github.com/docker/docker Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.23+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.23...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/getsentry/sentry-go](https://github.com/getsentry/sentry-go) from 0.18.0 to 0.20.0. - [Release notes](https://github.com/getsentry/sentry-go/releases) - [Changelog](https://github.com/getsentry/sentry-go/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-go@v0.18.0...v0.20.0) --- updated-dependencies: - dependency-name: github.com/getsentry/sentry-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add collumn and API model to store secrets * add logic to create cipher based on config * report encrypted secrets * only report secrets if not stored yet * set secrete encryption config in dp terraform helm chart * encode ciphertext with base64 to allow proper JSON communication
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.300 to 1.44.332. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.300...v1.44.332) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Current dependencies on/for this PR: |
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
parametalol
changed the title
|
Is this test being executed currently anywhere? Sounds like it should be failing? |
stehessel
approved these changes
Sep 5, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 0x656b694d, stehessel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kurlov
reviewed
Sep 5, 2023
|
New changes are detected. LGTM label has been removed. |
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the quota.md:
There are currently two quota backends -
Quota Management with Account Management Service (AMS)
and quota management list (default). The CLI flag
--quota-type={ams,quota-management-list}configures thequota backend at deploy time of fleet manager. Production instances of fleet manager are configured with
--quota-type=amsto verify quota against customer's SKU entitlements.