ROX-19478: Parameterize manager RDS secret name. #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
force-pushed
the
porridge/ROX-19478-parameterize
branch
from
277040c to
c2e13e1
Compare
|
/retest |
johannes94
approved these changes
Aug 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, porridge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For integration env we need to use a slightly different name to avoid clashes with the stage RDS which resides in the same appsre stage account.
Also updated the secrets baseline since presubmit asked me to 🤷
However I did not include all the changes applied by local pre-submit because they would fail in the CI presubmit check.
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.RDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
CI is enough.