-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-16317: Extract a reusable data plane deployment workflow. #913
Conversation
Also add github action files linter while at it.
3335d2c
to
986824b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring 👍. It would be even nicer to see the github actions linter as a pre-commit hook, but not critical.
PTAL @kovayur |
Ha, it's not as easy as I thought. Should I revert the latest commit, or do we want to fetch the tool in the precommit action? WDYT @kovayur ? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, porridge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Description
Another copy of the rollout workflow (for the PR check) would be too much.
So I'm extracting the common code into a reusable workflow.
One unclear thing is whether we should be setting
concurrency
in the reusable or in the caller workflow.One data point is that the linter complained about using
${{ inputs... }}
in the reusable workflow name, but does not complain when I use it in theconcurrency
field, so I'm hopeful it will work as intended.Also adding a GHA linter workflow while at it, stolen from
stackrox/stackrox
but usinglatest
rather than a pinned version, and running only when files in the.github
dir change.Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Test manual
Ran actionlint.