Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-16317: Extract a reusable data plane deployment workflow. #913

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

porridge
Copy link
Collaborator

@porridge porridge commented Apr 3, 2023

Description

Another copy of the rollout workflow (for the PR check) would be too much.
So I'm extracting the common code into a reusable workflow.

One unclear thing is whether we should be setting concurrency in the reusable or in the caller workflow.
One data point is that the linter complained about using ${{ inputs... }} in the reusable workflow name, but does not complain when I use it in the concurrency field, so I'm hopeful it will work as intended.

Also adding a GHA linter workflow while at it, stolen from stackrox/stackrox but using latest rather than a pinned version, and running only when files in the .github dir change.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

Ran actionlint.

Also add github action files linter while at it.
@porridge porridge requested a review from kovayur April 3, 2023 11:55
@porridge porridge temporarily deployed to development April 3, 2023 11:55 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the approved label Apr 3, 2023
@porridge porridge force-pushed the porridge/ROX-13747-second-stab branch from 3335d2c to 986824b Compare April 3, 2023 11:58
@porridge porridge temporarily deployed to development April 3, 2023 11:58 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development April 3, 2023 12:08 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development April 3, 2023 12:10 — with GitHub Actions Inactive
@porridge porridge temporarily deployed to development April 5, 2023 08:01 — with GitHub Actions Inactive
Copy link
Contributor

@kovayur kovayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring 👍. It would be even nicer to see the github actions linter as a pre-commit hook, but not critical.

.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
@porridge porridge temporarily deployed to development April 5, 2023 09:07 — with GitHub Actions Inactive
@porridge
Copy link
Collaborator Author

porridge commented Apr 5, 2023

PTAL @kovayur

@porridge
Copy link
Collaborator Author

porridge commented Apr 5, 2023

Executable `actionlint` not found

Ha, it's not as easy as I thought. Should I revert the latest commit, or do we want to fetch the tool in the precommit action? WDYT @kovayur ?

@kovayur kovayur temporarily deployed to development April 5, 2023 12:10 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the lgtm label Apr 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Contributor

kovayur commented Apr 5, 2023

/retest

@kovayur kovayur merged commit 3997175 into main Apr 6, 2023
@kovayur kovayur deleted the porridge/ROX-13747-second-stab branch April 6, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants