Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stackrox/stackrox version, including Segment fix #899

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

parametalol
Copy link
Contributor

@parametalol parametalol commented Mar 22, 2023

Description

Bumping stackrox/stackrox version which includes the fix (Group + delayed Track) for Segment events disorder: stackrox/stackrox#5195

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Testing

Unit tests in stackrox/stackrox.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@parametalol parametalol temporarily deployed to development March 22, 2023 09:30 — with GitHub Actions Inactive
@parametalol
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@parametalol parametalol force-pushed the michael/segment-group-track-delay branch from 776c644 to 5a922dd Compare March 23, 2023 10:27
@parametalol parametalol temporarily deployed to development March 23, 2023 10:27 — with GitHub Actions Inactive
@parametalol parametalol temporarily deployed to development March 23, 2023 10:27 — with GitHub Actions Inactive
@parametalol parametalol marked this pull request as ready for review March 23, 2023 10:31
@parametalol parametalol requested a review from stehessel March 23, 2023 10:31
@parametalol parametalol temporarily deployed to development March 23, 2023 10:31 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0x656b694d, stehessel
Once this PR has been reviewed and has the lgtm label, please assign dhaus67 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@parametalol parametalol merged commit be6db8e into main Mar 23, 2023
@parametalol parametalol deleted the michael/segment-group-track-delay branch March 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants