Pass the region from the parameter store to the fleetshard sync #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebensh
requested review from
kovayur and
vladbologa
and removed request for
kovayur
Use the parameter under the name CLUSTER_REGION, as it is stored with the cluster's parameters, not a "region" parameter group for the fleetshard sync
kovayur
approved these changes
Apr 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, kovayur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/retest-required |
kovayur
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Pass the region from the parameter store to the fleetshard sync * Update terraform_cluster.sh Use the parameter under the name CLUSTER_REGION, as it is stored with the cluster's parameters, not a "region" parameter group for the fleetshard sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass the cluster's region from parameter store to the Fleetshard Sync so that it creates RDS instances in the correct (local) region.
Checklist (Definition of Done)
[ ] Unit and integration tests addedTest manual[ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)[ ] Add the ticket number to the PR title if available, i.e.ROX-12345: ...[ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Test manual
Waited for https://github.com/stackrox/acs-fleet-manager-aws-config/pull/66 to merge.
Checked that parameter existed in Parameter Store.
Did not test the terraforming - we should push this commit to actually test the change using GHA, instead of trying to push the change locally using the script.