-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18428: report secret data to fleet-manager #1185
Conversation
Skipping CI for Draft Pull Request. |
23061f9
to
4f678fa
Compare
50bb47a
to
2d5be0b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -104,6 +107,8 @@ type CentralReconciler struct { | |||
useRoutes bool | |||
Resources bool | |||
routeService *k8s.RouteService | |||
secretService *k8s.SecretBackup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
secretService *k8s.SecretBackup | |
secretBackup *k8s.SecretBackup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
New changes are detected. LGTM label has been removed. |
4e248bb
to
88a76f4
Compare
Description
This PR adds the logic to report K8s secrets created by FS sync or the RHACS operator back to store them in fleet-manager (namely
central-tls
andcentral-db-password
). The secrets are encrypted using AWS KMS to ensure they are stored securely in FMs database and in transit. We need to create the KMS keys before merging this into main and deploying it to the stage environment. Because of that the PR: https://github.com/stackrox/acs-fleet-manager-aws-config/pull/117 has to be merged first.This is part of the Epic https://issues.redhat.com/browse/ROX-17060, the implementation to restore secrets if they are missing in the cluster will be done in another PR.
In this PR we implement following parts of the overall solution:
Checklist (Definition of Done)
Test manual
ROX-12345: ...
[ ] Add secret to app-interface Vault or Secrets Manager if necessary[ ] RDS changes were e2e tested manuallyTest manual