Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mouse support to SEND_STRING #8223

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Add mouse support to SEND_STRING #8223

merged 2 commits into from
Feb 23, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 22, 2020

Description

Allows something like SEND_STRING("QMK is the best thing ever!" SS_TAP(X_MS_BTN1));

  • Mouse keycode range exist within the 0xFF range used by register_code
  • SEND_STRING backing code uses register_code
  • register_code has magic handling for mouse keycodes

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team February 22, 2020 03:30
fauxpark
fauxpark approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add the short forms up the top 👍

@drashna drashna merged commit f76f9c7 into qmk:master Feb 23, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 25, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
034c505 
* 'master' of https://github.com/qmk/qmk_firmware: (108 commits)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  Update main.c (qmk#8198)
  format code according to conventions [skip ci]
  Fix QWIIC OLED for AVR (qmk#7769)
  VIA Support: KBD75 rev1/rev2 (qmk#8214)
  Update TMOv2 for new key (qmk#7759)
  Added custom keymap for preonic (qmk#7548)
  ...
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge remote-tracking branch 'upstream/master'
1362dc4 
* upstream/master: (26 commits)
  Fixed OS detection such that OSX doesn't take over the world (qmk#8248)
  [Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
  format code according to conventions [skip ci]
  New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
  Split - Avoid race condition during matrix_init_quantum (qmk#8235)
  Acheron VIA support (qmk#8204)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@zvecr @HokieGeek
Add mouse support to SEND_STRING (qmk#8223)
a986add 
* Add mouse support to SEND_STRING

* add short forms
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Mar 19, 2020
@zvecr @drashna
Add mouse support to SEND_STRING (qmk#8223)
6113ff5 
* Add mouse support to SEND_STRING

* add short forms
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@zvecr @c0psrul3
Add mouse support to SEND_STRING (qmk#8223)
90739a3 
* Add mouse support to SEND_STRING

* add short forms
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Mar 24, 2020
@zvecr @fdidron
Add mouse support to SEND_STRING (qmk#8223)
75ca366 
* Add mouse support to SEND_STRING

* add short forms
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@zvecr @sowbug
Add mouse support to SEND_STRING (qmk#8223)
ee1c903 
* Add mouse support to SEND_STRING

* add short forms
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr @kujawakk
Add mouse support to SEND_STRING (qmk#8223)
2f0c6df 
* Add mouse support to SEND_STRING

* add short forms
@zvecr zvecr deleted the feature/send_string_mouse branch April 28, 2020 01:14
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@zvecr @jakeisnt
Add mouse support to SEND_STRING (qmk#8223)
cbbd351 
* Add mouse support to SEND_STRING

* add short forms
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Add mouse support to SEND_STRING (qmk#8223)
0c6dcda 
* Add mouse support to SEND_STRING

* add short forms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @fauxpark @ridingqwerty