Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add zfrontier/big_switch #8205

Merged
merged 9 commits into from
Feb 24, 2020
Merged

[Keyboard] Add zfrontier/big_switch #8205

merged 9 commits into from
Feb 24, 2020

Conversation

carlxia
Copy link
Contributor

@carlxia carlxia commented Feb 20, 2020

Description

A keyboard designed by zFrontier with RGB backlight and only one switch. Two keymaps are provided,

  • keymap default has only the ENTER key.
  • keymap longtap enables more features like switching RGB backlight mode and input a random slogan by different press modes.

Types of Changes

  • Keyboard (addition or update)

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Feb 20, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better, thanks! Just a few small tweaks.

keyboards/zfrontier/big_switch/config.h Outdated Show resolved Hide resolved
keyboards/zfrontier/big_switch/config.h Outdated Show resolved Hide resolved
keyboards/zfrontier/big_switch/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c Outdated Show resolved Hide resolved
keyboards/zfrontier/big_switch/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team February 20, 2020 03:57
@carlxia
Copy link
Contributor Author

carlxia commented Feb 20, 2020

Looking much better, thanks! Just a few small tweaks.

Thanks and Appreciate your detailed code review very much! @fauxpark
I've added an overriding rules.mk in keymap/longtap.
Welcome if you have any new comments.

@drashna drashna requested a review from a team February 21, 2020 06:19
@carlxia
Copy link
Contributor Author

carlxia commented Feb 24, 2020

@fauxpark Hi Ryan, can this PR be merged now? thanks.

@fauxpark
Copy link
Member

@carlxia just that last thing on the default keymap, looks good to go otherwise.

@fauxpark fauxpark merged commit 40f7981 into qmk:master Feb 24, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 25, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
034c505 
* 'master' of https://github.com/qmk/qmk_firmware: (108 commits)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  Update main.c (qmk#8198)
  format code according to conventions [skip ci]
  Fix QWIIC OLED for AVR (qmk#7769)
  VIA Support: KBD75 rev1/rev2 (qmk#8214)
  Update TMOv2 for new key (qmk#7759)
  Added custom keymap for preonic (qmk#7548)
  ...
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge remote-tracking branch 'upstream/master'
1362dc4 
* upstream/master: (26 commits)
  Fixed OS detection such that OSX doesn't take over the world (qmk#8248)
  [Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
  format code according to conventions [skip ci]
  New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
  Split - Avoid race condition during matrix_init_quantum (qmk#8235)
  Acheron VIA support (qmk#8204)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@carlxia @fauxpark
@drashna @HokieGeek
[Keyboard] Add zfrontier/big_switch (qmk#8205)
15c39c0 
* add zfrontier/big_switch

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Ryan <[email protected]>

* add overriding keymap makefile

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/default/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* remove redundant defines

* taplong no longer needed

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@carlxia @fauxpark
@drashna @c0psrul3
[Keyboard] Add zfrontier/big_switch (qmk#8205)
4371765 
* add zfrontier/big_switch

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Ryan <[email protected]>

* add overriding keymap makefile

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/default/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* remove redundant defines

* taplong no longer needed

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@carlxia @fauxpark
@drashna @sowbug
[Keyboard] Add zfrontier/big_switch (qmk#8205)
7b02e7c 
* add zfrontier/big_switch

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Ryan <[email protected]>

* add overriding keymap makefile

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/default/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* remove redundant defines

* taplong no longer needed

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@carlxia @fauxpark
@drashna @kujawakk
[Keyboard] Add zfrontier/big_switch (qmk#8205)
7494496 
* add zfrontier/big_switch

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Ryan <[email protected]>

* add overriding keymap makefile

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/default/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* remove redundant defines

* taplong no longer needed

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@carlxia @fauxpark
@drashna @jakeisnt
[Keyboard] Add zfrontier/big_switch (qmk#8205)
49b811e 
* add zfrontier/big_switch

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/config.h

Co-Authored-By: Ryan <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Ryan <[email protected]>

* add overriding keymap makefile

* Update keyboards/zfrontier/big_switch/keymaps/longtap/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/zfrontier/big_switch/keymaps/default/keymap.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* remove redundant defines

* taplong no longer needed

Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlxia @fauxpark @drashna