Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature: PERMISSIVE_HOLD_PER_KEY #7994

Merged
merged 2 commits into from
Feb 25, 2020
Merged

New feature: PERMISSIVE_HOLD_PER_KEY #7994

merged 2 commits into from
Feb 25, 2020

Conversation

ridingqwerty
Copy link
Contributor

Description

Expands on the per-key tap-hold configuration options, allowing for fine-tuned control of exactly which keys are affected by PERMISSIVE_HOLD.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team January 25, 2020 21:10
@ridingqwerty ridingqwerty mentioned this pull request Feb 10, 2020
Closed
13 tasks
@drashna drashna requested a review from a team February 11, 2020 01:40
@ridingqwerty ridingqwerty merged commit b949343 into qmk:master Feb 25, 2020
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge remote-tracking branch 'upstream/master'
1362dc4 
* upstream/master: (26 commits)
  Fixed OS detection such that OSX doesn't take over the world (qmk#8248)
  [Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
  format code according to conventions [skip ci]
  New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
  Split - Avoid race condition during matrix_init_quantum (qmk#8235)
  Acheron VIA support (qmk#8204)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@ridingqwerty @GeorgeKoenig @HokieGeek
New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
6f71779 
* Implement 'PERMISSIVE_HOLD_PER_KEY'

* Document 'PERMISSIVE_HOLD_PER_KEY'

Co-authored-by: GeorgeKoenig <[email protected]>
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@ridingqwerty @GeorgeKoenig @c0psrul3
New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
38a2081 
* Implement 'PERMISSIVE_HOLD_PER_KEY'

* Document 'PERMISSIVE_HOLD_PER_KEY'

Co-authored-by: GeorgeKoenig <[email protected]>
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Mar 26, 2020
@ridingqwerty @GeorgeKoenig @drashna
New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
4dc91ca 
* Implement 'PERMISSIVE_HOLD_PER_KEY'

* Document 'PERMISSIVE_HOLD_PER_KEY'

Co-authored-by: GeorgeKoenig <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@ridingqwerty @GeorgeKoenig @sowbug
New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
4bc9412 
* Implement 'PERMISSIVE_HOLD_PER_KEY'

* Document 'PERMISSIVE_HOLD_PER_KEY'

Co-authored-by: GeorgeKoenig <[email protected]>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@ridingqwerty @GeorgeKoenig @kujawakk
New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
34a1763 
* Implement 'PERMISSIVE_HOLD_PER_KEY'

* Document 'PERMISSIVE_HOLD_PER_KEY'

Co-authored-by: GeorgeKoenig <[email protected]>
@sigprof
Copy link
Contributor

sigprof commented May 2, 2020

The common sense suggests that get_permissive_hold() should return true to enable the PERMISSIVE_HOLD behavior for the key; however, the actual implementation enables the permissive hold behavior if get_permissive_hold() returns false. Was this really intended? I just filed a bug report #8999 about this.

@sigprof sigprof mentioned this pull request May 2, 2020
Merged
7 tasks
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@ridingqwerty @GeorgeKoenig @jakeisnt
New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
9771605 
* Implement 'PERMISSIVE_HOLD_PER_KEY'

* Document 'PERMISSIVE_HOLD_PER_KEY'

Co-authored-by: GeorgeKoenig <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@ridingqwerty @GeorgeKoenig
New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
933178a 
* Implement 'PERMISSIVE_HOLD_PER_KEY'

* Document 'PERMISSIVE_HOLD_PER_KEY'

Co-authored-by: GeorgeKoenig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ridingqwerty @sigprof @drashna @zvecr @GeorgeKoenig