Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A proper send_string() for the Unicode feature #8155

Merged
merged 1 commit into from
Feb 23, 2020
Merged

A proper send_string() for the Unicode feature #8155

merged 1 commit into from
Feb 23, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Feb 12, 2020 •
edited
Loading

Description

This essentially supersedes (but does not deprecate or remove) send_unicode_hex_string(). Now you can use UTF-8 string literals in a send_string()y way, although it currently skips over surrogate pairs and code points higher than U+FFFF, as register_hex() is used instead of register_hex32() which is in unicodemap.c.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 12, 2020 05:54
@drashna drashna requested a review from a team February 23, 2020 22:43
@tzarc tzarc merged commit 371ff9d into qmk:master Feb 23, 2020
@fauxpark fauxpark deleted the send-unicode-string branch February 24, 2020 00:12
@fauxpark fauxpark mentioned this pull request Feb 24, 2020
Merged
13 tasks
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 25, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
034c505 
* 'master' of https://github.com/qmk/qmk_firmware: (108 commits)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  Update main.c (qmk#8198)
  format code according to conventions [skip ci]
  Fix QWIIC OLED for AVR (qmk#7769)
  VIA Support: KBD75 rev1/rev2 (qmk#8214)
  Update TMOv2 for new key (qmk#7759)
  Added custom keymap for preonic (qmk#7548)
  ...
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge remote-tracking branch 'upstream/master'
1362dc4 
* upstream/master: (26 commits)
  Fixed OS detection such that OSX doesn't take over the world (qmk#8248)
  [Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
  format code according to conventions [skip ci]
  New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
  Split - Avoid race condition during matrix_init_quantum (qmk#8235)
  Acheron VIA support (qmk#8204)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@fauxpark @HokieGeek
A proper send_string() for the Unicode feature (qmk#8155)
d667a65
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Mar 19, 2020
@fauxpark @drashna
A proper send_string() for the Unicode feature (qmk#8155)
88dcb11
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@fauxpark @c0psrul3
A proper send_string() for the Unicode feature (qmk#8155)
6d0af43
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Mar 24, 2020
@fauxpark @fdidron
A proper send_string() for the Unicode feature (qmk#8155)
84a0ba8
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@fauxpark @sowbug
A proper send_string() for the Unicode feature (qmk#8155)
bbe6d04
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@fauxpark @kujawakk
A proper send_string() for the Unicode feature (qmk#8155)
986a2d7
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@fauxpark @jakeisnt
A proper send_string() for the Unicode feature (qmk#8155)
72fc625
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
A proper send_string() for the Unicode feature (qmk#8155)
aba1e3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @tzarc