Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Wete #8229

Merged
merged 9 commits into from
Feb 25, 2020
Merged

[Keyboard] Add Wete #8229

merged 9 commits into from
Feb 25, 2020

Conversation

ramonimbao
Copy link
Contributor

Description

Add a new keyboard I'm currently developing: a southpaw full-sized keyboard nicknamed 'Wete'.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Feb 23, 2020
@zvecr zvecr requested a review from a team February 23, 2020 12:28
zvecr
zvecr requested changes Feb 23, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this inline with whats happening in #8206.

Basically,

  • use the default drivers/boards instead of the custom added ones
  • use core backlight

@ramonimbao
Copy link
Contributor Author

Thanks! I've updated it as you said, and have compiled it with no problems on my end.

zvecr
zvecr requested changes Feb 23, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also given your current setup, SPI, and I2C can be disabled within the chconf and mcuconf files.

keyboards/wete/bootloader_defs.h Outdated Show resolved Hide resolved
keyboards/wete/rules.mk Outdated Show resolved Hide resolved
keyboards/wete/wete.c Show resolved Hide resolved
keyboards/wete/readme.md Outdated Show resolved Hide resolved
keyboards/wete/readme.md Outdated Show resolved Hide resolved
keyboards/wete/readme.md Outdated Show resolved Hide resolved
@ramonimbao ramonimbao requested a review from zvecr February 23, 2020 13:15
@drashna
Copy link
Member

drashna commented Feb 23, 2020

Was this basically a one off board, or did you plan on selling them?

The reason that I ask, is that we tend to try to keep one off or small quantity boards and passion projects in the handwired folder, even if it's not a handwired board.

@ramonimbao
Copy link
Contributor Author

I'll be running a small group buy for the board. So far, there have been around 14 interested individuals for a total of 20 boards. Not sure if that counts as small quantity.

fauxpark
fauxpark requested changes Feb 24, 2020
View reviewed changes
keyboards/wete/readme.md Outdated Show resolved Hide resolved
keyboards/wete/readme.md Outdated Show resolved Hide resolved
keyboards/wete/wete.c Outdated Show resolved Hide resolved
@ramonimbao ramonimbao requested a review from fauxpark February 24, 2020 05:06
noroadsleft
noroadsleft requested changes Feb 24, 2020
View reviewed changes
keyboards/wete/info.json Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
keyboards/wete/wete.h Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 93c5307 into qmk:master Feb 25, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Feb 25, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
034c505 
* 'master' of https://github.com/qmk/qmk_firmware: (108 commits)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  Update main.c (qmk#8198)
  format code according to conventions [skip ci]
  Fix QWIIC OLED for AVR (qmk#7769)
  VIA Support: KBD75 rev1/rev2 (qmk#8214)
  Update TMOv2 for new key (qmk#7759)
  Added custom keymap for preonic (qmk#7548)
  ...
@ramonimbao ramonimbao mentioned this pull request Feb 25, 2020
Merged
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Feb 27, 2020
Merge remote-tracking branch 'upstream/master'
1362dc4 
* upstream/master: (26 commits)
  Fixed OS detection such that OSX doesn't take over the world (qmk#8248)
  [Keyboard] Add Prime_EXL Plus to handwired (qmk#8238)
  format code according to conventions [skip ci]
  New feature: PERMISSIVE_HOLD_PER_KEY (qmk#7994)
  Split - Avoid race condition during matrix_init_quantum (qmk#8235)
  Acheron VIA support (qmk#8204)
  `send_unicode_string()`: Add support for code points > 0xFFFF (qmk#8236)
  [Keyboard] Add Wete (qmk#8229)
  Improvements to extrakey HID descriptors (qmk#8156)
  Hineybush h87a lock indicators (qmk#8237)
  Add VIA support for Prime_L (qmk#8233)
  Hub16 - Bug removal + clean up code (qmk#8227)
  [Keyboard] ai03 Equinox (qmk#8224)
  [Keyboard] Add zfrontier/big_switch (qmk#8205)
  Gingham Update (qmk#8225)
  A proper `send_string()` for the Unicode feature (qmk#8155)
  Rollback PR qmk#7967 in preference of fixing I2C start/stop properly, in a followup PR. (qmk#8173)
  Add mouse support to SEND_STRING (qmk#8223)
  Add link to "Useful functions" in macro docs (qmk#7446)
  New functionality for cformat (qmk#7893)
  ...
@noroadsleft noroadsleft mentioned this pull request Feb 27, 2020
Closed
13 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@ramonimbao @HokieGeek
[Keyboard] Add Wete (qmk#8229)
dcf0af0 
* [Keyboard] Add Wete

* Fix width and height in Wete info.json

* Use default board files, core backlight, and disable RTC

* Disable I2C, SPI. Minor corrections

* Keymap typo update

* Add LAYOUT_all to info.json

* Remove extra spaces in README, delete matrix_*_kb functions

* Fix layout errors in wete.h, and some minor corrections

* Actually fix LAYOUT_all in info.json
@ramonimbao ramonimbao deleted the wete branch March 7, 2020 00:21
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@ramonimbao @c0psrul3
[Keyboard] Add Wete (qmk#8229)
d0a20f2 
* [Keyboard] Add Wete

* Fix width and height in Wete info.json

* Use default board files, core backlight, and disable RTC

* Disable I2C, SPI. Minor corrections

* Keymap typo update

* Add LAYOUT_all to info.json

* Remove extra spaces in README, delete matrix_*_kb functions

* Fix layout errors in wete.h, and some minor corrections

* Actually fix LAYOUT_all in info.json
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@ramonimbao @sowbug
[Keyboard] Add Wete (qmk#8229)
45aba3c 
* [Keyboard] Add Wete

* Fix width and height in Wete info.json

* Use default board files, core backlight, and disable RTC

* Disable I2C, SPI. Minor corrections

* Keymap typo update

* Add LAYOUT_all to info.json

* Remove extra spaces in README, delete matrix_*_kb functions

* Fix layout errors in wete.h, and some minor corrections

* Actually fix LAYOUT_all in info.json
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@ramonimbao @kujawakk
[Keyboard] Add Wete (qmk#8229)
2bef834 
* [Keyboard] Add Wete

* Fix width and height in Wete info.json

* Use default board files, core backlight, and disable RTC

* Disable I2C, SPI. Minor corrections

* Keymap typo update

* Add LAYOUT_all to info.json

* Remove extra spaces in README, delete matrix_*_kb functions

* Fix layout errors in wete.h, and some minor corrections

* Actually fix LAYOUT_all in info.json
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@ramonimbao @jakeisnt
[Keyboard] Add Wete (qmk#8229)
d53d265 
* [Keyboard] Add Wete

* Fix width and height in Wete info.json

* Use default board files, core backlight, and disable RTC

* Disable I2C, SPI. Minor corrections

* Keymap typo update

* Add LAYOUT_all to info.json

* Remove extra spaces in README, delete matrix_*_kb functions

* Fix layout errors in wete.h, and some minor corrections

* Actually fix LAYOUT_all in info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramonimbao @drashna @noroadsleft @fauxpark @zvecr