Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance release RC tests #818

Closed
60 tasks done
jonathanolson opened this issue Apr 13, 2017 · 11 comments
Closed
60 tasks done

Maintenance release RC tests #818

jonathanolson opened this issue Apr 13, 2017 · 11 comments
Assignees
Labels

Comments

@jonathanolson
Copy link
Contributor

jonathanolson commented Apr 13, 2017

The following RCs are available for for https://github.com/phetsims/phet-android-app/issues/16, phetsims/phetcommon#37 and phetsims/vibe#30. I'll comment when they are fully deployed.

The following complete list should be tested for:

The following subset of sims have the Vibe fix, and should be tested to ensure they have proper sound on iOS (in addition, spot-checking one to ensure sound is good elsewhere):

Also BASE includes fixes for phetsims/special-ops#68, and is a continuation of #795:

@jonathanolson
Copy link
Contributor Author

Not yet ready for tests (may need rc.2s on some). Once it IS ready, I'll pass to @ariel-phet for prioritization.

@jonathanolson
Copy link
Contributor Author

RCs are ready for testing.

@ariel-phet ariel-phet removed their assignment Apr 14, 2017
@ariel-phet
Copy link

@phet-steele these tests would be good to perform sooner than later (preferably before May 1) as we would like these releases published well before publishing the android app.

@phet-steele
Copy link

Also @ariel-phet, phetsims/vibe#30 is pretty serious so I'll more than likely get to these tests immediately.

@ariel-phet
Copy link

@phet-steele sounds good

@phet-steele
Copy link

@jonathanolson, balancing-chemical-equations shows no change with phet-android-app.

jonathanolson added a commit to phetsims/balancing-chemical-equations that referenced this issue Apr 14, 2017
@jonathanolson
Copy link
Contributor Author

Fixed balancing-chemical-equations, new RC linked in main list.

@phet-steele
Copy link

phet-steele commented Apr 14, 2017

Fixed, thanks.

@phet-steele
Copy link

phet-steele commented Apr 14, 2017

@jonathanolson Done! Everything went swimmingly. All runs included the brand, had pingver=3, and hid the appropriate items in the PhET menu with the query param. And sound worked, too.

@phet-steele phet-steele removed their assignment Apr 14, 2017
@jonathanolson
Copy link
Contributor Author

Ok, will be pushing out production releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants