Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to patch audio fix into 1.0 release branch? #824

Closed
pixelzoom opened this issue Apr 18, 2017 · 1 comment
Closed

how to patch audio fix into 1.0 release branch? #824

pixelzoom opened this issue Apr 18, 2017 · 1 comment

Comments

@pixelzoom
Copy link
Contributor

In #815 (comment), @phet-steele said:

@pixelzoom, as a reminder before rc.2, this sim will need to pick up changes from phetsims/vibe#30 (of which rc.1 currently suffers from).

and:

Actually, it may need the other two patches from #818?

Apparently there was a change to the audio API that broke all sims on Safari, and was recently fixed and patched. Unfortunately that fix was made after I created the 1.0 release branch, so the bug is still present in 1.0.0-rc.1. So we'll need to figure out how to patch this, or we'll need to do another full RC test with master branches of the fixed repo(s).

@pixelzoom
Copy link
Contributor Author

Whoops, wrong repo. Moved to phetsims/graphing-slope-intercept#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants