Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC test: Graphing Slope-Intercept 1.0.0-rc.1 #815

Closed
5 of 7 tasks
pixelzoom opened this issue Apr 11, 2017 · 12 comments
Closed
5 of 7 tasks

RC test: Graphing Slope-Intercept 1.0.0-rc.1 #815

pixelzoom opened this issue Apr 11, 2017 · 12 comments
Assignees
Labels

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 11, 2017

RC version:
http://www.colorado.edu/physics/phet/dev/html/graphing-slope-intercept/1.0.0-rc.1/graphing-slope-intercept_en.html

iFrame test:
http://www.colorado.edu/physics/phet/dev/html/graphing-slope-intercept/1.0.0-rc.1/graphing-slope-intercept_en-iframe.html

Text matrix:
https://docs.google.com/spreadsheets/d/1Tocnn1DCtML3rrYDJj4pTgQ96tE0caTQR4fqYeA0vuU/edit#gid=2

In addition to the test matrix, please perform these specific tests on 1 or 2 platforms:

  • ?stringTest=double (double all strings)
  • ?stringTest=long (excessively long strings)
  • ?stringTest=X (short strings)
  • ?stringTest=rtl (right-to-left text direction)
  • ?stringTest=xss (test for security issues, passes if it does NOT redirect to another page)
  • full screen test
  • screenshot test

Game challenges, and the rewards for a perfect score in each level, are specified in:
https://docs.google.com/document/d/1ztSRN1YE1BIGI1rsCBnZXzZQYvelSFySp4sDHPh2OJs/edit#

Sim-specific query parameters are in GLQueryParameters.js. These have been simplified a bit since 1.0.0-dev.1, so review them again.

Terminology is defined in implementation-notes.md.

For a list of the issues that were addressed during dev testing, see #812.

Please mention this issue in any GitHub issues that you create.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 11, 2017

@ariel-phet please set priority and assign.

@amanda-phet Graphing Slope-Intercept is now in RC testing.

@ariel-phet
Copy link

@phet-steele marking as high, currently after #807 is finished in the QA line

@ariel-phet ariel-phet removed their assignment Apr 11, 2017
@pixelzoom
Copy link
Contributor Author

@phet-steele It looks like RC testing has not started, so please hold off until I give the green light. phetsims/graphing-slope-intercept#11 required nontrivial changes to both graphing-slope-intercept and graphing-lines, so I'm going to delete 1.0.0-rc.1 and rebuild it when that issue is resolved.

@pixelzoom
Copy link
Contributor Author

@phet-steele I rebuilt 1.0.0-rc.1, so you may proceed with RC testing.

Note to self: Here's how I rebuilt 1.0.0-rc.1. I'm using the same shas, but picking up the changes to graphing-lines from master.

% cd graphing-slope-intercept
% git checkout 1.0
% grunt checkout-shas
% cd ../graphing-lines
% git checkout master
% cd ../graphing-slope-intercept
% grunt
% grunt deploy-rc

@phet-steele
Copy link

@pixelzoom, as a reminder before rc.2, this sim will need to pick up changes from phetsims/vibe/issues/30 (of which rc.1 currently suffers from).

@pixelzoom
Copy link
Contributor Author

Thanks. I was unaware of phetsims/vibe#30.

@phet-steele
Copy link

phet-steele commented Apr 18, 2017

Actually, it may need the other two patches from #818? (3 in total)

@pixelzoom
Copy link
Contributor Author

@jonathanolson Advice on how to integrate the fix for phetsims/vibe#30 into the release branch for this sim?

@pixelzoom
Copy link
Contributor Author

@phet-steele Picking up the audio fix is not going to be straightforward, so I moved it to its own issue. See phetsims/graphing-slope-intercept#17.

@pixelzoom
Copy link
Contributor Author

Due to significant code changes required to address phetsims/graphing-lines#78 (memory leak in Graphing Lines), @phet-steele and I agreed that this would be a good place to stop this RC test task. And prior to starting the next RC test, we should do another dev test of Graphing Lines.

Leaving this issue assigned to me, so that I can identify what needs to be regression tested in the next RC test.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Apr 25, 2017

The next RC test is deferred until we publish Graphing Lines 1.2.0. Ideally, this sim should use the same shas.

@pixelzoom
Copy link
Contributor Author

Graphing Lines 1.2.0 has been published, so we can proceed with the next RC task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants