Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable versions 1.2.1 and 1.2.2 were deployed with PhET-iO releases #272

Closed
jessegreenberg opened this issue Jun 2, 2017 · 2 comments
Closed
Assignees

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jun 2, 2017

The last official maintenance release that I was aware of was 1.2.0, which was deployed with phetsims/tasks#818. PhET-iO releases on May 9 and May 16 also published versions 1.2.1 and 1.2.2, which are unstable and include accessibility features that we did not want deployed to production.

@zepumph @jbphet can you help determine what happened? Did this happen because there is both a 1.2 branch and a 1.2-phetio branch?

In the mean time, what is the best way to revert deployed version? Can I build 2.0 again off of 2.0 SHAS and deploy-production?

@jessegreenberg jessegreenberg self-assigned this Jun 2, 2017
@jessegreenberg jessegreenberg changed the title Unstable versions 2.1 and 2.2 were deployed with a PhET-iO releases Unstable versions 2.1 and 2.2 were deployed with PhET-iO releases Jun 2, 2017
@jessegreenberg jessegreenberg changed the title Unstable versions 2.1 and 2.2 were deployed with PhET-iO releases Unstable versions 1.2.1 and 1.2.2 were deployed with PhET-iO releases Jun 2, 2017
@jessegreenberg
Copy link
Contributor Author

I talked with @jbphet, we think there are two possibilities for why this happened.

  • The build tools deployed to production because there are both a 1.2 branch and a 1.2-phetio branch.
  • In the deployment of 1.2.1 and 1.2.2 in the 1.2-phetio branch, the phetio brand flag might have been omitted.

Unsure of how the phetio build process works, but the second option seems likely. phetsims/tasks#848 is tracking a minor release for 1.3-phetio, so the first point should not happen in the next release.

To fix this, we will redeploy off of 1.2 SHAS, increment the version number to 1.2.3 as the latest version.

@jessegreenberg
Copy link
Contributor Author

1.2.3 was deployed as a maintenance release to fix this. Thanks for the help @jbphet and @phet-steele. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant