Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yotta messages should track brand directly. #37

Closed
jonathanolson opened this issue Mar 2, 2017 · 9 comments
Closed

Yotta messages should track brand directly. #37

jonathanolson opened this issue Mar 2, 2017 · 9 comments
Assignees

Comments

@jonathanolson
Copy link
Contributor

Give SHA to build-an-atom (@samreid and @jbphet) to cherry-pick.

Presumably this will increment the pingver.

@jonathanolson
Copy link
Contributor Author

Added and tested briefly above. Can you cherry-pick into a relevant phetcommon branch for build-an-atom's RC, build, and ensure that the request to immediate.gif has 'brand=phet-io'?

@jonathanolson jonathanolson assigned samreid and jbphet and unassigned jonathanolson Mar 2, 2017
@jonathanolson
Copy link
Contributor Author

SHA is 49b5cb0, so:

git cherry-pick 49b5cb0d6befc50e516598e52f4c90cb1f8be963

@jonathanolson
Copy link
Contributor Author

Will handle on server-side in my working copy changes. My comment // Only one protocol version is currently supported will never see the light of day!

@jonathanolson
Copy link
Contributor Author

Code to back-fill the brand server-side:

if ( protocolVersion === 2 ) {
  yottaInfo.brand = ( yottaInfo.version.indexOf( '-phetio' ) >= 0 ) ? 'phet-io' : 'phet';
}

@jbphet
Copy link
Contributor

jbphet commented Mar 22, 2017

This SHA was incorporated into the Build an Atom 1.4 branch, and should now be live on the published version v1.4.0, see phetsims/build-an-atom@6c084a7. @jonathanolson - can you verify that this is working as expected?

@jbphet jbphet assigned jonathanolson and unassigned jbphet Mar 22, 2017
@samreid
Copy link
Member

samreid commented Apr 13, 2017

It sounds like @jbphet and @jonathanolson are on the case, I'll unassign myself.

@samreid samreid removed their assignment Apr 13, 2017
@jonathanolson
Copy link
Contributor Author

@jonathanolson - can you verify that this is working as expected?

Build an Atom production is 1.2 (although there is a 1.4-phetio branch), and for some reason this doesn't seem to be live on the latest version of Build an Atom. Investigating.

@jonathanolson
Copy link
Contributor Author

jonathanolson commented Apr 14, 2017

EDIT: Ignore this, I found the link for the wrong sim.

I'm also very confused. https://phet-io.colorado.edu/sims/beers-law-lab/1.4.0-phetio/beers-law-lab_en-phetio.html (the only 1.4 version I could find on the phet-io website) doesn't event send Yotta messages, much less include the brand with them.

@jonathanolson
Copy link
Contributor Author

Found the right link in phet-io, confirmed that it is sending the brand.

jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/area-builder that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/arithmetic that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/atomic-interactions that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/forces-and-motion-basics that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/friction that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/neuron that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/plinko-probability that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/molarity that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/molecule-shapes that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/molecule-shapes-basics that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/molecules-and-light that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/ohms-law that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/ph-scale that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/resistance-in-a-wire that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/rutherford-scattering that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/states-of-matter that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/states-of-matter-basics that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/trig-tour that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/under-pressure that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/unit-rates that referenced this issue Apr 14, 2017
jonathanolson added a commit to phetsims/wave-on-a-string that referenced this issue Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants