-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yotta messages should track brand directly. #37
Comments
Added and tested briefly above. Can you cherry-pick into a relevant phetcommon branch for build-an-atom's RC, build, and ensure that the request to immediate.gif has 'brand=phet-io'? |
SHA is 49b5cb0, so: git cherry-pick 49b5cb0d6befc50e516598e52f4c90cb1f8be963 |
Will handle on server-side in my working copy changes. My comment |
Code to back-fill the brand server-side: if ( protocolVersion === 2 ) {
yottaInfo.brand = ( yottaInfo.version.indexOf( '-phetio' ) >= 0 ) ? 'phet-io' : 'phet';
} |
This SHA was incorporated into the Build an Atom 1.4 branch, and should now be live on the published version v1.4.0, see phetsims/build-an-atom@6c084a7. @jonathanolson - can you verify that this is working as expected? |
It sounds like @jbphet and @jonathanolson are on the case, I'll unassign myself. |
Build an Atom production is 1.2 (although there is a 1.4-phetio branch), and for some reason this doesn't seem to be live on the latest version of Build an Atom. Investigating. |
EDIT: Ignore this, I found the link for the wrong sim. I'm also very confused. https://phet-io.colorado.edu/sims/beers-law-lab/1.4.0-phetio/beers-law-lab_en-phetio.html (the only 1.4 version I could find on the phet-io website) doesn't event send Yotta messages, much less include the brand with them. |
Found the right link in phet-io, confirmed that it is sending the brand. |
Give SHA to build-an-atom (@samreid and @jbphet) to cherry-pick.
Presumably this will increment the pingver.
The text was updated successfully, but these errors were encountered: