Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Balloons and Static Electricity 1.2.0-rc.2 #795

Closed
jessegreenberg opened this issue Mar 3, 2017 · 11 comments
Closed

RC Test: Balloons and Static Electricity 1.2.0-rc.2 #795

jessegreenberg opened this issue Mar 3, 2017 · 11 comments
Assignees
Labels

Comments

@jessegreenberg
Copy link

jessegreenberg commented Mar 3, 2017

@ariel-phet @phet-steele @jbphet @arouinfar, Balloons and Static Electricity 1.2.0-rc.2 is ready for RC testing.

Link to sim

Link to iFrame

Test Matrix

Issues to Verify
This simulation has seen many changes for instrumentation of PhET-iO and accessibility. It has also had several model changes to fix miscellaneous bugs and outstanding issues. There are no specific issues to verify in this RC, but it requires full testing to deploy a version that has fixes for the model.

NOTE: This version should not include any accessibility features - tab navigation should be disabled.

If any new issues are found, please note them in https://github.com/phetsims/balloons-and-static-electricity/issues and reference this issue.

Assigning to @ariel-phet to prioritize.

@phet-steele
Copy link

@jessegreenberg there was already an rc test for a version 1.2.0-rc.1 in #513. Can you verify that the link you supplied above is the most up to date and not the same sim from a year ago?

jessegreenberg added a commit to phetsims/balloons-and-static-electricity that referenced this issue Mar 7, 2017
@jessegreenberg
Copy link
Author

Good catch @phet-steele. I bumped to RC.2, and built a new sim. I updated the links in the original issue ticket.

Here is the history and reason there was previously an 1.2.0 that went through an RC test:

  • Before the summer redeploy, there was an a branch for 1.1.0 in balloons-and-static-electricity that went through some RC testing, but never passed, and was never deployed.
  • Rather than update the SHAs for the version in this branch @jessegreenberg created a new branch 1.2.0 off of master and created an RC for this version for the summer redeploy.
  • Shortly after, the dev team decided it was best to have continuous versioning, and that it was better to continue the 1.1 branch, pulling master SHAs into that branch and starting over.
  • So the 1.2 branch was then deleted, though the 1.2.0 version on spot (and its testing task) remained.

But now we are ready to continue with a 1.2.0 release. I bumped the rc version number so that internal testing documentation can continue with the next RC version, but the deployed version will continue with 1.2.0.

Assigning back to @phet-steele and @ariel-phet for priority.

@jessegreenberg jessegreenberg changed the title RC Test: Balloons and Static Electricity 1.2.0-rc.1 RC Test: Balloons and Static Electricity 1.2.0-rc.2 Mar 8, 2017
@phet-steele
Copy link

I bumped the rc version number so that internal testing documentation can continue with the next RC version

Specifically, so the testing matrix doesn't become confusing with multiple tabs of the same version.

@phet-steele
Copy link

Issue above was referenced wrong, ignore it.

@phet-steele
Copy link

@jessegreenberg see the one issue above and to add Ethan to the credits, and don't forget to grab changes from phetsims/special-ops/issues/68. Testing is done!

@jonathanolson
Copy link
Contributor

@phet-steele noted this passed except for the patches. It would be easier for me to include it directly with the maintenance patches I'm applying.

jonathanolson added a commit to phetsims/balloons-and-static-electricity that referenced this issue Apr 14, 2017
@jonathanolson
Copy link
Contributor

Next RC link for BASE: http://www.colorado.edu/physics/phet/dev/html/balloons-and-static-electricity/1.2.0-rc.3/balloons-and-static-electricity_en.html.

Do you want a separate testing task, or treat it as part of #818?

@phet-steele
Copy link

@jonathanolson the only changes made were the patches, which are part of the maintenance release anyway. We will wrap this rc in with #818.

@jessegreenberg
Copy link
Author

Thanks @jonathanolson!

@jessegreenberg
Copy link
Author

jessegreenberg commented Apr 14, 2017

@phet-steele BASE was bumped to rc.4 for phetsims/balloons-and-static-electricity#72, but a spot check in #818 should still be fine. I updated links for BASE in #818.

@phet-steele
Copy link

phet-steele commented Apr 14, 2017

Going to go ahead and close this. rc.4 testing went well in #818 and will be deployed from that issue. Thank you @jonathanolson and @jessegreenberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants