Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing images/license.txt and assets/ #72

Closed
pixelzoom opened this issue Sep 5, 2013 · 15 comments
Closed

missing images/license.txt and assets/ #72

pixelzoom opened this issue Sep 5, 2013 · 15 comments

Comments

@pixelzoom
Copy link
Contributor

All images in images/ must be accounted for in images/license.txt.

And any images that were created by PhET should have their original source files (.ai, .psd,...) checked in to assets/.

@jonathanolson
Copy link
Contributor

Looks like 1.2 is going to go out without resolving this?:

>> license exception for BALLOONS_AND_STATIC_ELECTRICITY/charge-transfer-beep.mp3: This might NOT meet the license requirements for PhET, the use is t
emporary until something new is created
>> license exception for BALLOONS_AND_STATIC_ELECTRICITY/charge-transfer-beep.ogg: This might NOT meet the license requirements for PhET, the use is t
emporary until something new is created
>> license exception for BALLOONS_AND_STATIC_ELECTRICITY/bounds-beep.mp3: This might NOT meet the license requirements for PhET, the use is temporary
until something new is created
>> license exception for BALLOONS_AND_STATIC_ELECTRICITY/bounds-beep.ogg: This might NOT meet the license requirements for PhET, the use is temporary
until something new is created

@pixelzoom
Copy link
Contributor Author

@jessegreenberg created audio/license.json and appears to have pushed the audio files in question. Perhaps he can elaborate.

@jessegreenberg
Copy link
Contributor

Thanks for catching, assets removed for 1.2 branch and won't be part of the release. They should be removed from master at this point too, we were playing with some ideas but nothing was meant long term use at this point.

@jessegreenberg
Copy link
Contributor

These assets were removed, and this issue should have been closed long ago. Closing.

@jessegreenberg
Copy link
Contributor

But this issue was originally about missing image assets. It looks like the balloons are still missing from assets/. @arouinfar do you know if we can find these somewhere?

@arouinfar
Copy link
Contributor

@jessegreenberg BASE predates me, so I don't know who would've created the balloon assets, but maybe @ariel-phet has some idea.

@arouinfar arouinfar assigned ariel-phet and unassigned arouinfar Aug 16, 2017
@arouinfar
Copy link
Contributor

I didn't see any BASE-related artwork backed up on Drive.

@pixelzoom
Copy link
Contributor Author

Perhaps the BASE artwork lives in Unfuddle, since it was originally a Java sim?

@pixelzoom
Copy link
Contributor Author

In Unfuddle SVN, trunk/simulations-java/simulations/balloons/assets/, I see:

balloon-meg.gif
sweater-300x436.gif

@arouinfar
Copy link
Contributor

arouinfar commented Aug 16, 2017

Good idea @pixelzoom, but I don't think these are the assets we're looking for
sweater-300x436
balloon-meg

@ariel-phet
Copy link

@arouinfar @jessegreenberg - my guess is the balloons were drawn by Noah P.

Perhaps the easiest thing would be to get Cheryl to redraw the balloons so we have a current .ai file

My guess is she will be able to reproduce these extremely quickly.

@arouinfar
Copy link
Contributor

@ariel-phet I created a task for Cheryl to re-draw the balloons (referenced above), so unassigning myself.

@arouinfar arouinfar removed their assignment Aug 28, 2017
@arouinfar
Copy link
Contributor

@jessegreenberg I've emailed you the new balloon assets.

@jessegreenberg
Copy link
Contributor

I added the new assets, they are looking great.
capture

@jessegreenberg
Copy link
Contributor

Since we checked in the balloon .ai assets we now have all assets for this sim, There is also an images/license.json. I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants