-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing images/license.txt and assets/ #72
Comments
Looks like 1.2 is going to go out without resolving this?:
|
@jessegreenberg created audio/license.json and appears to have pushed the audio files in question. Perhaps he can elaborate. |
Thanks for catching, assets removed for 1.2 branch and won't be part of the release. They should be removed from master at this point too, we were playing with some ideas but nothing was meant long term use at this point. |
These assets were removed, and this issue should have been closed long ago. Closing. |
But this issue was originally about missing image assets. It looks like the balloons are still missing from assets/. @arouinfar do you know if we can find these somewhere? |
@jessegreenberg BASE predates me, so I don't know who would've created the balloon assets, but maybe @ariel-phet has some idea. |
I didn't see any BASE-related artwork backed up on Drive. |
Perhaps the BASE artwork lives in Unfuddle, since it was originally a Java sim? |
In Unfuddle SVN, trunk/simulations-java/simulations/balloons/assets/, I see: balloon-meg.gif |
Good idea @pixelzoom, but I don't think these are the assets we're looking for |
@arouinfar @jessegreenberg - my guess is the balloons were drawn by Noah P. Perhaps the easiest thing would be to get Cheryl to redraw the balloons so we have a current .ai file My guess is she will be able to reproduce these extremely quickly. |
@ariel-phet I created a task for Cheryl to re-draw the balloons (referenced above), so unassigning myself. |
@jessegreenberg I've emailed you the new balloon assets. |
Since we checked in the balloon .ai assets we now have all assets for this sim, There is also an images/license.json. I think this issue can be closed. |
All images in images/ must be accounted for in images/license.txt.
And any images that were created by PhET should have their original source files (.ai, .psd,...) checked in to assets/.
The text was updated successfully, but these errors were encountered: