Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: Gas Properties 1.1.0-dev.18 #1100

Closed
13 of 14 tasks
pixelzoom opened this issue Jun 20, 2024 · 6 comments
Closed
13 of 14 tasks

Dev Test: Gas Properties 1.1.0-dev.18 #1100

pixelzoom opened this issue Jun 20, 2024 · 6 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jun 20, 2024

Dev Test

Mentions: @arouinfar @kathy-phet @KatieWoe

Simulation links

Test Matrix

Please include all (non-screen reader) feature testing in these records if applicable.

  • Latest macOS, Safari (Time = 2.75hrs )
  • Latest iOS, Safari (Time = 1)
  • Windows 10/11, Firefox (Time = 2.75hrs )
  • Windows 11, Chrome (Time =2.5)
  • Latest Chrome OS, Chrome (Time = 2hrs)

Light testing, or optionally skip if time crunch:

  • Latest macOS, Chrome (Time =.5)
  • Windows 10, Chrome (Time = )

If PhET-iO is being tested:

  • Latest macOS, Safari (Time = 2)
  • Windows 10, Chrome (Time =2.75 )
  • Windows 11, Firefox (Time = 3.5 )
  • Latest iOS, Safari (Time = 1.5)
  • Windows 11, Chrome (Time =2.5 )

Features included

  • PhET-iO
  • Dynamic Locale
  • Alternative Input
  • UI Sound
  • Sonification
  • Description
  • Voicing

Focus and Special Instructions

There is no need to dev-test the derivative sims (gases-intro, diffusion).

Note these known problems that are unnecessary to report:

Issues to Verify

These issues should have the "status:ready-for-review" label. Unless an issue says to close after verifying, assign the
issue back to the developer.


For QA...

General features

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.
  • Check the Game Up harness on one platform.

PhET-iO features

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.

Accessibility features

What to Test

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Interactive Description
    • Sound and Sonification
    • Pan and Zoom
    • Mobile Description
    • Voicing
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).

Screen Readers

This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@pixelzoom pixelzoom added the QA:dev-test Dev test before an RC label Jun 20, 2024
@github-project-automation github-project-automation bot moved this to Upcoming Tests (by priority) in QA Pipeline Jun 20, 2024
@pixelzoom pixelzoom changed the title Dev Test: Gas Properties {{VERSION}} Dev Test: Gas Properties 1.1.0-dev.17 Jun 20, 2024
@pixelzoom
Copy link
Contributor Author

@Nancy-Salpepi said that QA is ready to start this test. So I published 1.1.0-dev.17 and updated the links in this issue.

@Nancy-Salpepi Nancy-Salpepi moved this from Upcoming Tests (by priority) to Active Tests (max 5, by priority) in QA Pipeline Jun 20, 2024
@KatieWoe KatieWoe moved this from Active Tests (max 5, by priority) to Upcoming Tests (by priority) in QA Pipeline Jun 21, 2024
@KatieWoe KatieWoe moved this from Upcoming Tests (by priority) to Active Tests (max 5, by priority) in QA Pipeline Jun 21, 2024
@arouinfar
Copy link
Contributor

@Nancy-Salpepi @KatieWoe please note that the examples.md doc has not yet been created. I'll update this issue when it's ready for testing off of main.

@Nancy-Salpepi
Copy link
Contributor

On hold until a new dev-test is build that incorporates recent common-code changes.

@Nancy-Salpepi Nancy-Salpepi moved this from Active Tests (max 5, by priority) to Upcoming Tests (by priority) in QA Pipeline Jun 24, 2024
@pixelzoom
Copy link
Contributor Author

In Slack#dev-public, @jonathanolson said:

FYI, pushed some button layout changes as part of phetsims/scenery#1513 and phetsims/scenery#1482. Please let me know if anything seems problematic.

Button contents should now be properly resizable, line width is handled in a consistent manner, and round buttons can be made sizable in one orientation (to match the width/height of things in a VBox/HBox, for instance) while maintaining their circular shape.

This seemed like a significant enough common-code change that we should publish a new version for this dev test. That new version is 1.1.0-dev.18, and I've adjusted the title and links for this issue.

@Nancy-Salpepi
Copy link
Contributor

Calling QA here.

@Nancy-Salpepi Nancy-Salpepi moved this from Active Tests (max 5, by priority) to Dev & RC: ready for next steps in QA Pipeline Jun 26, 2024
@phetsims phetsims deleted a comment from KatieWoe Jul 3, 2024
@pixelzoom
Copy link
Contributor Author

All issues are being tracked separately, so closing this issue.

@github-project-automation github-project-automation bot moved this from Dev & RC: ready for next steps to Done in QA Pipeline Jul 3, 2024
pixelzoom added a commit to phetsims/gas-properties that referenced this issue Jul 3, 2024
@Luisav1 Luisav1 moved this from Done to Dev & RC: ready for next steps in QA Pipeline Jul 19, 2024
@KatieWoe KatieWoe moved this from Dev & RC: ready for next steps to Done in QA Pipeline Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
Status: Done
Development

No branches or pull requests

5 participants