Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider round-item layout with preferred sizes #1482

Closed
jonathanolson opened this issue Oct 20, 2022 · 1 comment
Closed

Consider round-item layout with preferred sizes #1482

jonathanolson opened this issue Oct 20, 2022 · 1 comment
Assignees
@jonathanolson @marlitas

Comments

@jonathanolson
Copy link
Contributor

Should a RoundButton "disobey" one of its two preferred sizes (width/height) if they differ? Should it just take the smallest size?
jonathanolson added a commit to phetsims/sun that referenced this issue Jun 17, 2024
@jonathanolson
Button layout overhaul, see phetsims/scenery#1513 and phetsims/scener…
83e71b5 
…y#1482
jonathanolson added a commit to phetsims/sun that referenced this issue Jun 21, 2024
@jonathanolson
RoundButton sizability improvements, see phetsims/scenery#1513, phets…
2ba166d 
…ims/scenery#1482
jonathanolson added a commit to phetsims/sun that referenced this issue Jun 21, 2024
@jonathanolson
Removing aspectRatio on ButtonNode, see phetsims/scenery#1482, phetsi…
998ffbc 
…ms/scenery#1513
jonathanolson added a commit to phetsims/sun that referenced this issue Jun 21, 2024
@jonathanolson
Adjusting minWidth/minHeight to not include stroke, see phetsims/scen…
e287794 
…ery#1482, phetsims/scenery#1513
@pixelzoom pixelzoom mentioned this issue Jun 24, 2024
Closed
14 tasks
@jonathanolson
Copy link
Contributor Author

Handled above, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

@marlitas marlitas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @marlitas