Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently unable to hide a particle type in the Average Speed Panel #277

Closed
Nancy-Salpepi opened this issue Jun 25, 2024 · 3 comments
Closed

Comments

@Nancy-Salpepi
Copy link

While testing phetsims/qa#1100, on the Energy Screen I noticed that it is currently not possible to hide one of the particle types in the Average Speed panel.

If I set averageSpeedAccordionBox.heavyNumberDisplay.visibleProperty or averageSpeedAccordionBox.lightNumberDisplay.visibleProperty to false, a value will no longer show, but the particle icon is still present. Wondering if there is an easy way to solve this?

Screenshot 2024-06-25 at 12 27 56 PM

I thought that perhaps an instructor may want to only focus on the relationship between temperature, KE and speed. Currently, it is possible to show only 1 particle type everywhere else on this screen (remove radio buttons under pump, remove particle type in Particles panel, remove checkbox groups for the graphs).

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 1, 2024

Meeting with @arouinfar and @Nancy-Salpepi:

Set visibility of particle icons based on visibility of NumberDisplay instances. See AverageSpeedAccordionBox.ts.

Feature averageSpeedAccordionBox.heavyNumberDisplay.visibleProperty and averageSpeedAccordionBox.lightNumberDisplay.visibleProperty.

@pixelzoom
Copy link
Contributor

averageSpeedAccordionBox.heavyNumberDisplay.visibleProperty and averageSpeedAccordionBox.lightNumberDisplay.visibleProperty are now featured. Setting them to false also hides their associated particle icons.

@Nancy-Salpepi please review, close if OK.

@Nancy-Salpepi
Copy link
Author

Looks great. I can now completely hide one particle type on the Energy Screen!
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants