-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory test for 1.1 release #222
Comments
Testing 1.1.0-dev.16 on macOS 14.5 + Chrome 126. I see no evidence of memory leaks. Details... phet brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.16/phet/gas-properties_en_phet.html?fuzz. No memory leaks noted. Heap snapsnots were taken at 1-minute intervals, and stabilized at ~110MB. phet-io brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.16/phet-io/gas-properties_all_phet-io.html?postMessageOnError&phetioStandalone&fuzz. No memory leaks noted. Heap snapsnots were taken at 1-minute intervals, and stabilized at ~130MB. |
Please verify the above memory testing results for dev test phetsims/qa#1100. OK to close if memory testing looks OK. |
@KatieWoe said:
The memory tests in #222 (comment) were done with 1.1.0-dev.16, published 6/17/24. Dev test phetsims/qa#1100 was done with 1.1.0-dev.18, published 6/24/24. It's possible that a leak could have snuck in during the 7 days between those versions. I'll do another test with a new dev version. |
Links for next memory tests: https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.19/phet/gas-properties_all_phet.html Testing on macOS 14.5 + Chrome 126. |
Testing 1.1.0-dev.19 on macOS 14.5 + Chrome 126. There may be a very slow memory leak, but nothing to be concerned about in practice. Details... phet brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.19/phet/gas-properties_en_phet.html?fuzz. Heap snapsnots were taken at 1-minute intervals, with 10 minutes between Snapshots 9 & 10. Heap size was observed to go down once (Snapshot 8). There may be a very slow memory leak, but nothing to be concerned about in practice. phet-io brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.19/phet-io/gas-properties_all_phet-io.html?postMessageOnError&phetioStandalone&fuzz. Heap snapsnots were taken at 1-minute intervals, with 10 minutes between Snapshots 9 & 10. Heap size was observed to go down once (Snapshot 6). As with phet brand, there may be a very slow memory leak, but nothing to be concerned about in practice. |
I'll keep this open for verification in 1.1.0-rc.1. |
Please verify memory tests (phet and phet-io brands) for phetsims/qa#1107. |
Thanks @KatieWoe. We won't be making any changes that affect memory management going forward, so closing this issue. |
Reopening because we have a suspected memory problem on iPad. From #289 (comment):
|
#289 turned out to be caused by WebGL, not memory related. I did another heap size test, and heap size still stabilizes ~140MB. Re "PaintColorProperty (related to StopwatchNode) and SpriteInstance", I didn't see anything alarming. There may be slow leaks, but tracking them down seems like more trouble than it's worth. So... re-closing this issue. |
For #191 ... Memory testing should be done before the sim goes into dev test, for phet and phet-io brands.
The text was updated successfully, but these errors were encountered: