Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory test for 1.1 release #222

Closed
Tracked by #1100 ...
pixelzoom opened this issue Apr 9, 2024 · 13 comments
Closed
Tracked by #1100 ...

Memory test for 1.1 release #222

pixelzoom opened this issue Apr 9, 2024 · 13 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Apr 9, 2024

For #191 ... Memory testing should be done before the sim goes into dev test, for phet and phet-io brands.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 17, 2024

Testing 1.1.0-dev.16 on macOS 14.5 + Chrome 126. I see no evidence of memory leaks.

Details...


phet brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.16/phet/gas-properties_en_phet.html?fuzz. No memory leaks noted. Heap snapsnots were taken at 1-minute intervals, and stabilized at ~110MB.

screenshot_3367

phet-io brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.16/phet-io/gas-properties_all_phet-io.html?postMessageOnError&phetioStandalone&fuzz. No memory leaks noted. Heap snapsnots were taken at 1-minute intervals, and stabilized at ~130MB.

screenshot_3368

@pixelzoom
Copy link
Contributor Author

Please verify the above memory testing results for dev test phetsims/qa#1100.

OK to close if memory testing looks OK.

@KatieWoe
Copy link
Contributor

Looking at the phet-brand, the memory test looks a bit worse, and seems to be leaking at least a bit.
growingmem

@KatieWoe
Copy link
Contributor

Same thing for PhET-iO Memory
samemem

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 9, 2024

@KatieWoe said:

... the memory test looks a bit worse, and seems to be leaking at least a bit.

The memory tests in #222 (comment) were done with 1.1.0-dev.16, published 6/17/24.

Dev test phetsims/qa#1100 was done with 1.1.0-dev.18, published 6/24/24.

It's possible that a leak could have snuck in during the 7 days between those versions. I'll do another test with a new dev version.

@pixelzoom pixelzoom changed the title Memory testing Memory test for 1.1 release Jul 9, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 9, 2024

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 9, 2024

Testing 1.1.0-dev.19 on macOS 14.5 + Chrome 126. There may be a very slow memory leak, but nothing to be concerned about in practice.

Details...


phet brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.19/phet/gas-properties_en_phet.html?fuzz. Heap snapsnots were taken at 1-minute intervals, with 10 minutes between Snapshots 9 & 10. Heap size was observed to go down once (Snapshot 8). There may be a very slow memory leak, but nothing to be concerned about in practice.

screenshot_3409

phet-io brand was tested with https://phet-dev.colorado.edu/html/gas-properties/1.1.0-dev.19/phet-io/gas-properties_all_phet-io.html?postMessageOnError&phetioStandalone&fuzz. Heap snapsnots were taken at 1-minute intervals, with 10 minutes between Snapshots 9 & 10. Heap size was observed to go down once (Snapshot 6). As with phet brand, there may be a very slow memory leak, but nothing to be concerned about in practice.

screenshot_3410

@pixelzoom
Copy link
Contributor Author

I'll keep this open for verification in 1.1.0-rc.1.

@pixelzoom
Copy link
Contributor Author

Please verify memory tests (phet and phet-io brands) for phetsims/qa#1107.

@KatieWoe
Copy link
Contributor

Memory tests look similar to before. Small but non-worrying leak.
PhET Brand:
slight
PhET-iO:
slight2

@pixelzoom
Copy link
Contributor Author

Thanks @KatieWoe. We won't be making any changes that affect memory management going forward, so closing this issue.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 23, 2024

Reopening because we have a suspected memory problem on iPad. From #289 (comment):

@samreid noted that heap comparisons indicate leaks with PaintColorProperty (related to StopwatchNode) and SpriteInstance. Hard to believe that this would crash the sim in 10 seconds, but I'll reopen #222 and investigate.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jul 23, 2024

#289 turned out to be caused by WebGL, not memory related.

I did another heap size test, and heap size still stabilizes ~140MB. Re "PaintColorProperty (related to StopwatchNode) and SpriteInstance", I didn't see anything alarming. There may be slow leaks, but tracking them down seems like more trouble than it's worth.

So... re-closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants