Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive highlight missing from bicycle pump #273

Closed
Nancy-Salpepi opened this issue Jun 21, 2024 · 2 comments
Closed

Interactive highlight missing from bicycle pump #273

Nancy-Salpepi opened this issue Jun 21, 2024 · 2 comments
Assignees
@Nancy-Salpepi
Labels
status:ready-for-review type:bug

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.5

Browser
Safari 17.5

Problem description
For phetsims/qa#1100, the bicycle pump is missing the interactive highlight for the mouse.

Visuals

bikePump.mp4
pixelzoom added a commit to phetsims/scenery-phet that referenced this issue Jul 1, 2024
@pixelzoom
add interactive highlight for bicycle pump handle, phetsims/gas-prope…
74f1121 
…rties#273
@pixelzoom
Copy link
Contributor

The interactive highlight was missing in common code, should have been added as part of phetsims/scenery-phet#848. I've fixed that in phetsims/scenery-phet@74f1121.

@Nancy-Salpepi please verify, close if OK.

@pixelzoom pixelzoom assigned Nancy-Salpepi and unassigned pixelzoom Jul 1, 2024
@Nancy-Salpepi
Copy link
Author

Fixed on main. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nancy-Salpepi Nancy-Salpepi

Labels
status:ready-for-review type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelzoom @Nancy-Salpepi