Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhET-iO instrumentation #92

Closed
pixelzoom opened this issue Oct 17, 2019 · 10 comments
Closed

PhET-iO instrumentation #92

pixelzoom opened this issue Oct 17, 2019 · 10 comments
Labels
design:phet-io status:blocks-sim-publication

Comments

@pixelzoom
Copy link
Contributor

pH Scale: Basics is on the desired list of sims for a client. That sim is a derivative (subset), so this will actually involve instrumenting pH Scale.

The current status (according to @kathy-phet) is: not high on the client's list, so not high priority. Probably something we need to start thinking about in the beginning of 2020.
pixelzoom referenced this issue Jan 29, 2020
@pixelzoom
add top-level (Screen, ScreenView, Model) tandems
581d11a
pixelzoom referenced this issue in phetsims/ph-scale-basics Jan 29, 2020
@pixelzoom
add top-level (Screen, ScreenView, Model) tandems
168d05d
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 29, 2020 •
edited
Loading

This now has a milestone - "around end of March or mid April" 2020.

@pixelzoom pixelzoom self-assigned this Jan 29, 2020
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 29, 2020
@pixelzoom
add phet-io to supportedBrands for ph-scale and ph-scale-basics, phet…
336e2da 
…sims/ph-scale#92
pixelzoom added a commit that referenced this issue Jan 29, 2020
@pixelzoom
add phet-io to supportedBrands for ph-scale and ph-scale-basics, #92
a6a93e2
@pixelzoom
Copy link
Contributor Author

I'm added phet-io to supportedBrands in package.json, and added top-level (Screen, ScreenView, Model) tandems. So this is ready to start basic instrumentation.

pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
generate API files for ph-scale, #92
2cb1644
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
generate API files for ph-scale-basics, phetsims/ph-scale#92
3ae8b5d
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
partial instrumentation, phetsims/ph-scale#92
2de6329
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
partial instrumentation, #92
a8b8e50
pixelzoom added a commit to phetsims/axon that referenced this issue Jan 30, 2020
@pixelzoom
partial instrumentation, phetsims/ph-scale#92
80a355b
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
pass tandem to Screen.super, phetsims/ph-scale#92
c6cc7ee
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
pass tandem to Screen.super, #92
3343cf4
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
basic instrumentation of Macro screen, phetsims/ph-scale#92
8d9a92f
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
basic instrumentation of Macro screen, #92
770896b
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
basic instrumentation of Micro screen, #92
b8074de
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
instrument Solution, phetsims/ph-scale#92
dda4865
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
instrument Solution, #92
2902127
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
basic instrumentation of My Solution screen, #92
8112881
pixelzoom added a commit to phetsims/axon that referenced this issue Jan 30, 2020
@pixelzoom
add 'L' for phetsims/ph-scale#92
6a6de29
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
first attempt at SoluteIO, phetsims/ph-scale#92
fa2f709
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
first attempt at SoluteIO, #92
a9f7edc
@pixelzoom
Copy link
Contributor Author

I did an instrumentation sprint to see what issues I'd run into. Most of the basic instrumentation is done. Look for "TODO #92" comments in the code to identify things that need to be be discussed, addressed, etc.

pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
instrumentation of SoluteIO, phetsims/ph-scale#92
cf765ad
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
instrumentation of SoluteIO, #92
799c136
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
TODOs, #92
3a5897f
pixelzoom added a commit that referenced this issue Jan 30, 2020
@pixelzoom
instrument graph drag handlers, #92
ff621af
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Jan 30, 2020
@pixelzoom
instrument dropper drag handler, phetsims/ph-scale#92
9f2f7cb
pixelzoom added a commit to phetsims/ph-scale-basics that referenced this issue Feb 6, 2020
@pixelzoom
https://github.com/phetsims/ph-scale/issues/92
7900bcd
pixelzoom added a commit that referenced this issue Feb 6, 2020
@pixelzoom
https://github.com/phetsims/ph-scale/issues/92
dec5f52
pixelzoom added a commit that referenced this issue Feb 6, 2020
@pixelzoom
rename pHIndicatorNode, #92
ab38f07
This was referenced Feb 6, 2020
Closed
Closed
Closed
Closed
Closed
Closed
@arouinfar
Copy link
Contributor

Review all open GitHub issues. Are there any that need to be addressed before this sim can be published out of master?

I do not see any issues opened prior to the PhET-iO work that would need to be addressed before publication.

After browsing the Studio tree... Which additional subcomponents of view elements should be instrumented?

It would be best if the TODOs in #92 (comment) could be addressed before @kathy-phet and I review the sim in studio. @pixelzoom can you re-assign us when it's ready for review?

pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
delete TODOs #92
19fd29a
pixelzoom added a commit that referenced this issue Feb 11, 2020
@pixelzoom
create linked elements from view Nodes back to their view Properties, #…
bad094a 
…92
@pixelzoom pixelzoom mentioned this issue Feb 11, 2020
Closed
@pixelzoom pixelzoom mentioned this issue Feb 20, 2020
Closed
4 tasks
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 20, 2020 •
edited
Loading

All PhET-iO instrumentation requests have been addressed, and published in https://phet-dev.colorado.edu/html/ph-scale/1.4.0-dev.11/phet-io/.

Feedback on initial instrumentation has been requested in #117.

@pixelzoom pixelzoom mentioned this issue Feb 20, 2020
Closed
pixelzoom added a commit to phetsims/axon that referenced this issue Feb 29, 2020
@pixelzoom
add abbreviated units needed by ph-scale, phetsims/ph-scale#92
418d7f3
@pixelzoom pixelzoom removed their assignment Mar 10, 2020
@pixelzoom
Copy link
Contributor Author

Feedback on initial PhET-iO instrumentation was completed in #117, and all resulting GitHub issues have been either addressed or deferred. The sim is now ready to identify featured elements using Studio, tracking in #146.

@pixelzoom pixelzoom mentioned this issue Mar 24, 2020
Closed
pixelzoom added a commit that referenced this issue Mar 24, 2020
@pixelzoom
doc colorStopRatio, #92
42c472f
pixelzoom added a commit that referenced this issue Mar 24, 2020
@pixelzoom
doc colorStopColor, #92
ec633ad
@arouinfar arouinfar mentioned this issue Apr 6, 2020
Closed
7 tasks
@pixelzoom
Copy link
Contributor Author

"Featured" design #146 was complete on 4/16/20.

When blocking issues have been addressed, dev versions will be published and provided to the client in #164.

@pixelzoom
Copy link
Contributor Author

Dev version was provided to the client awhile ago. Feedback was received, no change requests. So closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design:phet-io status:blocks-sim-publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pixelzoom @ariel-phet @kathy-phet @arouinfar