Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to beakerNode and solutionNode #108

Closed
pixelzoom opened this issue Feb 6, 2020 · 1 comment
Closed

changes to beakerNode and solutionNode #108

pixelzoom opened this issue Feb 6, 2020 · 1 comment
Assignees
@pixelzoom
Labels
dev:phet-io

Comments

@pixelzoom
Copy link
Contributor

2/6/20 design meeting. From #92:

  • beakerNode and solutionNode are currently siblings. Should solutionNode be a child of beakerNode, so that the solution is "in" the beaker? Same question for volumeIndicatorNode and neutralIndicatorNode.

Decision: Don't instrument solutionNode. Make beakerNode.visibleProperty read-only.
@pixelzoom pixelzoom self-assigned this Feb 6, 2020
@pixelzoom pixelzoom mentioned this issue Feb 6, 2020
Closed
pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
do not instrument SolutionNode, #108
7ef53db
pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
make beakerNode.visibleProperty read-only, #108
039a94a
@pixelzoom
Copy link
Contributor Author

Done, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom