Skip to content

Commit

Permalink
make beakerNode.visibleProperty read-only, #108
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Feb 7, 2020
1 parent 7ef53db commit 039a94a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
10 changes: 9 additions & 1 deletion js/common/view/BeakerNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,15 @@ define( require => {
options = merge( {

// phet-io
tandem: Tandem.REQUIRED
tandem: Tandem.REQUIRED,

// BeakerNode should not be hideable, but its subcomponents are.
// See https://github.com/phetsims/ph-scale/issues/108
phetioComponentOptions: {
visibleProperty: {
phetioReadOnly: true
}
}
}, options );

super( options );
Expand Down
6 changes: 3 additions & 3 deletions js/phet-io/ph-scale-phet-io-elements-baseline.js
Original file line number Diff line number Diff line change
Expand Up @@ -3961,7 +3961,7 @@ window.phet.phetio.phetioElementsBaseline = assert &&
"phetioHighFrequency": false,
"phetioIsArchetype": false,
"phetioPlayback": false,
"phetioReadOnly": false,
"phetioReadOnly": true,
"phetioState": true,
"phetioStudioControl": true,
"phetioTypeName": "PropertyIO<BooleanIO>"
Expand Down Expand Up @@ -6600,7 +6600,7 @@ window.phet.phetio.phetioElementsBaseline = assert &&
"phetioHighFrequency": false,
"phetioIsArchetype": false,
"phetioPlayback": false,
"phetioReadOnly": false,
"phetioReadOnly": true,
"phetioState": true,
"phetioStudioControl": true,
"phetioTypeName": "PropertyIO<BooleanIO>"
Expand Down Expand Up @@ -10552,7 +10552,7 @@ window.phet.phetio.phetioElementsBaseline = assert &&
"phetioHighFrequency": false,
"phetioIsArchetype": false,
"phetioPlayback": false,
"phetioReadOnly": false,
"phetioReadOnly": true,
"phetioState": true,
"phetioStudioControl": true,
"phetioTypeName": "PropertyIO<BooleanIO>"
Expand Down

0 comments on commit 039a94a

Please sign in to comment.