Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument Solute #103

Closed
pixelzoom opened this issue Feb 6, 2020 · 5 comments
Closed

instrument Solute #103

pixelzoom opened this issue Feb 6, 2020 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 6, 2020

From #92:

  • Do we need an API for solutes? What do you want to be able to inspect about a solute?

2/6/20 design meeting decision: phetioID, nameProperty, pH

@pixelzoom pixelzoom self-assigned this Feb 6, 2020
pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
Copy link
Contributor Author

I instrumented SoluteIO as requested, and tested in Studio and State Wrapper.

Inspecting the Solute instances shows none of the desired information. E.g.:

screenshot_101

Inspecting soluteProperty does show the desired info:

screenshot_102

There was a long-ish discussion about this on the Slack phet-io channel. This is apparently a PhET-iO deficiency, and @zepumph created https://github.com/phetsims/phet-io/issues/1616.

So this is blocked until this is addressed generally in Studio.

pixelzoom added a commit that referenced this issue Feb 19, 2020
@pixelzoom
Copy link
Contributor Author

@samreid pointed out that Solute was phetioState: false. Changing that to true shows the state information, see below.

@arouinfar please test drive in master, inspect solutes under phScale.global.model.solutes. If this looks sufficient, feel free to close.

screenshot_135

@arouinfar
Copy link
Contributor

Looks good in master @pixelzoom, closing.

@zepumph
Copy link
Member

zepumph commented Jan 22, 2021

Note that we changes this implementation over in https://github.com/phetsims/phet-io/issues/1616 with c665cba. Because we no longer to require it to be phetioState to get studio info about the solutes. Anyone please feel free to reopen if needed, but things are still the same. . .

This is what the same studio look now holds:

image

@pixelzoom
Copy link
Contributor Author

I'll take your word for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants