-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instrument Solute #103
Comments
I instrumented SoluteIO as requested, and tested in Studio and State Wrapper. Inspecting the Solute instances shows none of the desired information. E.g.: Inspecting There was a long-ish discussion about this on the Slack phet-io channel. This is apparently a PhET-iO deficiency, and @zepumph created https://github.com/phetsims/phet-io/issues/1616. So this is blocked until this is addressed generally in Studio. |
@samreid pointed out that @arouinfar please test drive in master, inspect solutes under |
Looks good in master @pixelzoom, closing. |
Note that we changes this implementation over in https://github.com/phetsims/phet-io/issues/1616 with c665cba. Because we no longer to require it to be phetioState to get studio info about the solutes. Anyone please feel free to reopen if needed, but things are still the same. . . This is what the same studio look now holds: |
I'll take your word for it. |
From #92:
2/6/20 design meeting decision: phetioID, nameProperty, pH
The text was updated successfully, but these errors were encountered: