TODOs, #92

phetsims · Jan 30, 2020 · 3a5897f · 3a5897f
1 parent 799c136
commit 3a5897f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/js/common/view/PHMeterNode.js b/js/common/view/PHMeterNode.js
@@ -1,6 +1,7 @@
 // Copyright 2014-2020, University of Colorado Boulder
 
 //TODO #92 instrument pHValueProperty and ExpandCollapseButton, do any other subcomponents need to be instrumented?
+//TODO #92 PHMeterNode probably needs to be restructured to support desired tandem structure
 /**
  * pH meter for the 'Micro' and 'My Solution' screens.
  * Origin is at top left.

diff --git a/js/common/view/graph/GraphNode.js b/js/common/view/graph/GraphNode.js
@@ -1,5 +1,6 @@
 // Copyright 2013-2020, University of Colorado Boulder
 
+//TODO #92 which subcomponents need to be instrumented?
 //TODO #92 instrument thin vertical lines?
 /**
  * Container for all components related to the graph feature.

diff --git a/js/macro/view/NeutralIndicatorNode.js b/js/macro/view/NeutralIndicatorNode.js
@@ -1,6 +1,6 @@
 // Copyright 2013-2020, University of Colorado Boulder
 
-//TODO #92 how to totally disable this feature from PhET-iO?
+//TODO #92 how to totally disable this feature from PhET-iO? query parameter? {Boolean} featureEnabledProperty?
 /**
  * Indicator that the solution is neutral.
  * This consists of 'Neutral' on a translucent background.

diff --git a/js/mysolution/model/MySolutionModel.js b/js/mysolution/model/MySolutionModel.js
@@ -30,7 +30,7 @@ define( require => {
       // @public Beaker, everything else is positioned relative to it. Offset constants were set by visual inspection.
       this.beaker = new Beaker( new Vector2( 750, 580 ), new Dimension2( 450, 300 ) );
 
-      //TODO #92 this is problematic, we probably do not want to instrument sub-elements soluteVolumeProperty and waterVolumeProperty
+      //  TODO #92 this is problematic, we probably do not want to instrument sub-elements soluteVolumeProperty and waterVolumeProperty
       //TODO #92 a new solute is created for every pH change by Solute.createCustom
       // @public Solution in the beaker
       this.solution = new Solution( new Property( Solute.createCustom( 7 ) ), 0.5, 0, this.beaker.volume, {