Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instrumentation of mySolution.model #109

Closed
pixelzoom opened this issue Feb 6, 2020 · 1 comment
Closed

instrumentation of mySolution.model #109

pixelzoom opened this issue Feb 6, 2020 · 1 comment
Assignees
@pixelzoom
Labels
dev:phet-io

Comments

@pixelzoom
Copy link
Contributor

2/6/20 design meeting. From #92:

  • In My Solutions screen, there is just a solution, whose pH we can be changed. There is nothing in UI related to solutes or solvent (water). But it uses the same model as the other screens, so there are Properties present that we probably don't want to see: soluteVolumeProperty and waterVolumeProperty. Should we hide these for this screen?

Decision: Hide soluteVolumeProperty and waterVolumeProperty.
@pixelzoom pixelzoom self-assigned this Feb 6, 2020
@pixelzoom pixelzoom mentioned this issue Feb 6, 2020
Closed
pixelzoom added a commit that referenced this issue Feb 7, 2020
@pixelzoom
instrumentation of mySolution.model, #109
0b67d03
@pixelzoom
Copy link
Contributor Author

Done.

Here's the solution instrumentation in the Macro and Micro screens:

screenshot_103

Here's the instrumentation in the My Solution screen:

screenshot_104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom