Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for disabling auto-fill feature #104

Closed
pixelzoom opened this issue Feb 6, 2020 · 3 comments
Closed

add support for disabling auto-fill feature #104

pixelzoom opened this issue Feb 6, 2020 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 6, 2020

2/6/20 design meeting. From #92:

  • There's a feature that autofills the beaker at startup and reset, or when a new solute is selected. It's used in ph-scale, but not in ph-scale-basics. Do we need to be able to disable this feature?

Decision: Yes. Add autoFillEnabledProperty

@pixelzoom
Copy link
Contributor Author

Added:

phScale.macroScreen.model.autoFillEnabledProperty
phScale.microScreen.model.autoFillEnabledProperty

To test:

  1. Start sim in Studio
  2. Select a solute from the combo box, note that the beaker automatically fills to 0.5L
  3. Change autoFillEnabledProperty to false
  4. Select a solute from the combo box, note that the beaker remains empty
  5. Press Reset All button, note that the beaker remains empty
  6. Change autoFillEnabledProperty to true
  7. Select a solute from the combo box, note that the beaker automatically fills to 0.5L

@arouinfar please verify in master.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 7, 2020

QA will need to know about this issue. So when it's verified, please change label to "status:fixed-awaiting-deploy".

@arouinfar
Copy link
Contributor

Looks good in master @pixelzoom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants