Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies so we no longer need npm install --legacy-peer-deps #150

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Aug 19, 2022

Resolves #134.

We have two direct dependencies which do not have new releases that support React 17, but which we no longer need:

With those two adjustments, all of our production dependencies support React 17 and npm install no longer fails when used without the --legacy-peer-deps flag. There are still a lot of peer dependency warnings related to Storybook's dependencies that are not compatible with React 17. I tried upgrading to the latest Storybook (and also to their prerelease versions) and that didn't resolve those warnings, so I left Storybook alone in this PR and limited its scope to the errors that were causing npm install to fail.

It seems these warnings may eventually go away if we upgrade to a future version of Storybook which only has dependencies that support React 17. Links I was looking at as part of figuring this out:

I opened #151 to track that after this is merged.

@mturley mturley changed the title Remove unnecessary dependencies to so we no longer need npm install --legacy-peer-deps Remove unnecessary dependencies so we no longer need npm install --legacy-peer-deps Aug 22, 2022
@mturley mturley merged commit 62e92b7 into patternfly:main Aug 22, 2022
@mturley mturley deleted the fix-peer-deps branch August 22, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot resolve peer dependencies when running npm install without --legacy-peer-deps
2 participants