Fix README on javascript branch #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturley
force-pushed
the
js-update-readme
branch
from
1b20e34 to
03215b7
Compare
nicolethoen
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116
In addition to
startbeing incorrectly used in the README instead ofstart:dev, the README was still describing the use ofyarneven though the repo switched to using the npm CLI at some point. Also,--legacy-peer-depsis required on this branch with newer versions of npm since it is currently using outdated dependencies that don't explicitly support React 17. (we need to port changes from #150 to this branch if we intend to maintain it).