chore(upgrade): upgrade deps, fix storybook #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgutride
approved these changes
Jan 12, 2021
use localhost instead of 0.0.0.0 for host so app opens correctly on windows use enzyme-adapter-react-17 to ensure jest test works remove stub async module support prevent url from changing when selecting SkipToContent component update readme screenshot preview patch storybook
seanforyou23
force-pushed
the
deps-upgrade
branch
from
08ca5a6 to
ab2dd0d
Compare
bhanvimenghani
pushed a commit
to bhanvimenghani/patternfly-react-seed
that referenced
this pull request
Mar 18, 2022
use localhost instead of 0.0.0.0 for host so app opens correctly on windows use enzyme-adapter-react-17 to ensure jest test works remove stub async module support prevent url from changing when selecting SkipToContent component update readme screenshot preview patch storybook
|
Note for posterity: since this PR removed the stub async route support (and the DynamicImport file orphaned here was later removed in #108) but the |
This was referenced Aug 19, 2022
mturley
added a commit
to mturley/patternfly-react-seed
that referenced
this pull request
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades runtime and development dependencies to latest version and puts storybook back in to a semi-functional state. Storybook still seems to have issues with webpack 5. Currently storybook is completely broken, but with this PR it at least boots up. That said, when you navigate to the Support component story you get the following error. I spent a bit of time looking at it but didn't find a solution just yet. Figured I'd post this PR for review in the mean time in case someone else knows what gives.
http://patternfly-react-seed.surge.sh/
http://patternfly-react-seed-storybook.surge.sh/
Steps toward fixing #100
Invalidates #65
use
localhostinstead of0.0.0.0for dev hostname so app opens correctly on windowsuse enzyme-adapter-react-17 to ensure jest test works
remove stub async module support
prevent url from changing when selecting SkipToContent component
update readme screenshot preview