Focus new content on route changes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanforyou23
commented
Jul 15, 2019
seanforyou23
force-pushed
the
route-change-focus-content
branch
from
7a6d30b to
2e6d218
Compare
seanforyou23
changed the title
listen for route changes, send focus to the new content after route changes add react styles pkg, adjust webpack config specify main container element id allow for sending route props to page components ensure focus is sent after sync and async routing alike bump pf version to consume changes in react-core
seanforyou23
force-pushed
the
route-change-focus-content
branch
from
2c3552d to
a1467f5
Compare
dgutride
approved these changes
Jul 30, 2019
|
Note for posterity: this feature was broken on the Support page by the removal of the async route feature in #103. See #103 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some code that ensures focus is placed on new content after route changes. This has the effect of causing screen readers to read the content aloud upon loading new page content. This helps ensure users receive adequate feedback in response to their actions and ensures they are oriented after page transitions and don't have to needlessly re-find the content after switching views.
It also works for async routes!
It builds on top of #56 and is dependent on patternfly/patternfly-react#2519.
Should help close #55