Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies so we no longer need npm install --legacy-peer-deps #150

Merged
merged 4 commits into from
Aug 22, 2022
Merged

Remove unnecessary dependencies so we no longer need npm install --legacy-peer-deps #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e68e867
Remove unused dependency enzyme-adapter-react-16
mturley Aug 19, 2022
de9f7d5
Remove isAsync (see https://github.com/patternfly/patternfly-react-se…
mturley Aug 19, 2022
df31c1e
Remove dependency on react-router-last-location
mturley Aug 19, 2022
460c72d
Remove --legacy-peer-deps flag from CI, run install without it to upd…
mturley Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
with:
node-version: lts/*
- name: Install dependencies
run: npm install --legacy-peer-deps # TODO remove --legacy-peer-deps after https://github.com/patternfly/patternfly-react-seed/issues/134 is fixed
run: npm install
- name: Run eslint
run: npm run lint
test:
Expand All @@ -32,7 +32,7 @@ jobs:
with:
node-version: lts/*
- name: Install dependencies
run: npm install --legacy-peer-deps # TODO remove --legacy-peer-deps after https://github.com/patternfly/patternfly-react-seed/issues/134 is fixed
run: npm install
- name: Run tests
run: npm run test
build:
Expand All @@ -46,6 +46,6 @@ jobs:
with:
node-version: lts/*
- name: Install dependencies
run: npm install --legacy-peer-deps # TODO remove --legacy-peer-deps after https://github.com/patternfly/patternfly-react-seed/issues/134 is fixed
run: npm install
- name: Attempt a build
run: npm run build
Loading