Fix #153/#154 : MultipleChoice/ItemSelection Interaction View #225
Conversation
tests to verify correctness. Also, added a method to facilitate notifying of DataProvider changes on the UI thread.
…dered initialization.
… it up to the data controller, and start adding tests.
Conflicts: domain/build.gradle domain/src/main/java/org/oppia/domain/exploration/ExplorationDataController.kt Also, migrate the data controller to the retriever.
AnswerClassificationController, and attempted to make ExplorationProgressController thread-safe. The thread-safety led to significant interface changes in the progress controller, and led to discovering some issues with the mediator live data approach to interop coroutines and LiveData. This locking mechanism will need to change since the optimal solution requires resolving #90.
with the current MediatorLiveData implementation (see #90 for more context). Fix existing progress controller tests and add a few more. All current progress controller tests are passing.
…ation support for the second test exploration (about_oppia).
…-controller' into introduce-load-exploration-part-1
…yer-content-interaction
Separated this in its own PR.
|
@BenHenning in this PR we are trying to fetch |
app/src/main/java/org/oppia/app/player/state/InteractionAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
| interactionInstanceId = "MultipleChoiceInput" | ||
| assertEquals(interactionInstanceId, "MultipleChoiceInput") | ||
| onView(withId(R.id.rvInteractions)).perform( | ||
| RecyclerViewActions.actionOnItemAtPosition<RecyclerView.ViewHolder>(2,click())) |
There was a problem hiding this comment.
@BenHenning Veena has added this library 'androidx.test.espresso:espresso-contrib:3.1.0', which helps in testing recyclerview items. Can I use this in my test-cases related to RecyclerView, #204
There was a problem hiding this comment.
@BenHenning @veena14cs
We should not use this library because this library only provide click actions and there is no mechanism to check the content of an item.
Th solution for this is in my PR #204
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
|
@veena14cs please address the feedback in #223 that applies here as well, specifically: let's introduce the interaction views in isolation with dedicated tests rather than hooking them up to state fragment. That would should be done downstream once the interactions are checked in. |
…ub.com/oppia/oppia-android into exploration-player-content-interaction
|
Duplicate of this PR is created #258 with all the fixes. |
Explanation
This PR is duplicate of #196. It contains UI structure for Multiple choice and item selection interactions, and fixes #153 and #154.
Do not merge this PR.
Issues:
Values for multiple choice are of type InteractionObject. No protos found to fetch list of values.
Exploration Id is missing in the protos defined.
Reference Design Doc: https://docs.google.com/document/d/1HFwDFcqenAXepbYr5rfawGHvkeBZpYvNMs228AWLn24/edit?usp=sharing