Fix #151: Lowfi numeric input interaction view part 2 #223

nikitamarysolomanpvt · 2019-10-10T09:01:40Z

Replicated from #190

Explanation

Part 1: #220
Part 2: This PR contains Numeric input view and Fix #151 .

Reference Mock

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/c4b0dfb3-53b4-491e-a759-818e096183fd/Lesson-1-a-v-Exploration-Player-Numeric-Input-No-A

Reference Design Doc

https://docs.google.com/document/d/1QigNdZeMBy-JjHW26QH4qT0UtCyzfvW0xEaStSdY9gM/edit?usp=sharing

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is assigned to an appropriate reviewer.

…d NumericInput from dummy data welcome.json ,welcome.json file "init_state_name"modified to "Numeric input",

…d NumericInput from dummy data welcome.json

… numbertextinputlayout onbutton click. on button click listner implemented

rt4914 · 2019-10-10T09:53:58Z

@nikitamarysolomanpvt Approach is correct. You can proceed ahead and finish this PR.

domain/src/main/assets/welcome.json

nikitamarysolomanpvt · 2019-10-10T10:02:24Z

@nikitamarysolomanpvt Approach is correct. You can proceed ahead and finish this PR.

Ok Thank You

rt4914 · 2019-10-11T05:38:07Z

@nikitamarysolomanpvt

Regarding PR description.

Do not mention that test-case is in progress in description, better mention this in a top-level comment.
You have linked this PR to Fix #150, #151, #155: TextInputInteractionView, NumericInputInteractionView, FractionInputInteractionView #190 , I would suggest linking this current PR to Fix #150, #151, #155: TextInputInteractionView, NumericInputInteractionView, FractionInputInteractionView #190 and close Fix #150, #151, #155: TextInputInteractionView, NumericInputInteractionView, FractionInputInteractionView #190
Reference link to mock is incorrect, please update that.

rt4914

Have some nit changes to do.

app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt

app/src/main/res/layout/state_fragment.xml

app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt

nikitamarysolomanpvt · 2019-10-11T05:52:52Z

@nikitamarysolomanpvt

Regarding PR description.

Do not mention that test-case is in progress in description, better mention this in a top-level comment.

You have linked this PR to Fix #150, #151, #155: TextInputInteractionView, NumericInputInteractionView, FractionInputInteractionView #190 , I would suggest linking this current PR to Fix #150, #151, #155: TextInputInteractionView, NumericInputInteractionView, FractionInputInteractionView #190 and close Fix #150, #151, #155: TextInputInteractionView, NumericInputInteractionView, FractionInputInteractionView #190

Reference link to mock is incorrect, please update that.

Okay

nikitamarysolomanpvt · 2019-10-11T05:52:58Z

Test case is in progress

Moved test case to StateFragment

nikitamarysolomanpvt · 2019-10-12T11:41:44Z

domain/src/main/assets/welcome.json

@@ -160,7 +160,14 @@
          }
        ],
        "confirmed_unclassified_answers": [],
-        "customization_args": {},
+        "customization_args": {


This is added for testing numeric input interaction view

BenHenning

Thanks @nikitamarysolomanpvt. Took a deep dive on the PR. Please let me know if you have any questions.

app/src/main/java/org/oppia/app/customview/inputInteractionView/NumericInputInteractionView.kt

BenHenning · 2019-10-18T06:40:23Z

app/src/main/java/org/oppia/app/customview/inputInteractionView/NumericInputInteractionView.kt

+    attributes()
+  }
+
+  constructor(context: Context?, placeholder: String) : this(context!!) {


Do we need to dynamically create the view? I wouldn't expect that since we're inflating it using LayoutInflater rather than directly constructing it.

app/src/main/java/org/oppia/app/customview/inputInteractionView/NumericInputInteractionView.kt

app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt

BenHenning · 2019-10-18T06:47:38Z

app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt

+    launchedActivity = activityTestRule.launchActivity(intent)
+    onView(withId(R.id.test_number_input_interaction_view)).perform(ViewActions.clearText(), ViewActions.typeText("9"))
+    activityTestRule.activity.requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE
+    activityTestRule.activity.requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_PORTRAIT


This isn't sufficient to trigger a configuration change. We can use ActivityScenario.recreate() for this purpose. The orientation change actually may not be needed; recreate may be enough to fully recreate the activity.

@nikitamarysolomanpvt Check TopicTrainFragmentTest file you can do this similarly here.

Its pending

app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt

…ated as per PR review of Ben, other nit changes

BenHenning

Thanks @nikitamarysolomanpvt. This LGTM! Please feel free to submit once my comments are addressed.

app/src/main/java/org/oppia/app/customview/interaction/NumericInputInteractionView.kt

app/src/main/res/values/dimens.xml

app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt

…ion-view-part-2' of https://github.com/oppia/oppia-android into text-input-lowfi-numeric-input-interaction-view-part-2

…View low-fi (#246) * NumberInputInteractionView dynamically created on state interaction id NumericInput from dummy data welcome.json ,welcome.json file "init_state_name"modified to "Numeric input", * NumberInputInteractionView dynamically created on state interaction id NumericInput from dummy data welcome.json * added fetch button, and fetch textview to fetch the data from dynamic numbertextinputlayout onbutton click. on button click listner implemented * nit changes * nit changes * nit changes * nit changes * nit changes * numericInputTypeView test case is in progress * numericInputTypeView test case is in progress * nit changes as per #223 * nit changes as per #223 * On configuration changes save and restore the text of numericInputType * Test Cases for NumericInputInteractionView, Moved test case to StateFragment * Test Cases for NumericInputInteractionView, Moved test case to StateFragment,PR suggestions updated * PR suggestions updated * PR suggestions updated * Merge branch 'develop' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs # Conflicts: # app/build.gradle # app/src/main/AndroidManifest.xml # app/src/main/res/values/styles.xml * nit changes as per PR review * nit changes as per PR review * nit changes as per PR review * nit changes as per PR review * Number input test Activity test cases * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * setReal type in getPendingAnswer * updated test cases, disabled long click to prevent pasting value * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * nit changes * NumericInputInteractionViewTestActivity renamed to InputInteractionViewTestActivity and test case updated * nit changes * nit changes * nit changes * nit * NumericInputInteractionView attributes are moved to xml,testcases updated as per PR review of Ben, other nit changes * NumericInputInteractionView attributes are moved to xml,testcases updated as per PR review of Ben, other nit changes * TextInputInteractionView * TextInputInteractionView * test cases * nit * nit * nit * nit * nit * Merge branches 'develop' and 'lowfi-input-interaction-views' of https://github.com/oppia/oppia-android into lowfi-input-interaction-views # Conflicts: # app/src/main/java/org/oppia/app/activity/InputInteractionViewTestActivity.kt # app/src/main/java/org/oppia/app/customview/interaction/NumericInputInteractionView.kt # app/src/main/res/layout/activity_numeric_input_interaction_view_test.xml # app/src/main/res/values/dimens.xml # app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt * nit * nit * nit * nit * Merge branches 'develop' and 'text-input-lowfi-numeric-input-interaction-view-part-2' of https://github.com/oppia/oppia-android into text-input-lowfi-numeric-input-interaction-view-part-2 # Conflicts: # app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt * nit * NumberWithUnitsInputInteractionView * nit * nit * NumberWithUnitsInputInteractionView * moved InputInteractionViewTestActivityTest to testing folder

nikitamarysolomanpvt added 4 commits October 9, 2019 19:21

NumberInputInteractionView dynamically created on state interaction i…

faca25a

…d NumericInput from dummy data welcome.json ,welcome.json file "init_state_name"modified to "Numeric input",

NumberInputInteractionView dynamically created on state interaction i…

c9b5919

…d NumericInput from dummy data welcome.json

added fetch button, and fetch textview to fetch the data from dynamic…

6235dfb

… numbertextinputlayout onbutton click. on button click listner implemented

nit changes

3ab9ae3

nikitamarysolomanpvt requested a review from rt4914 October 10, 2019 09:04

nikitamarysolomanpvt commented Oct 10, 2019

View reviewed changes

domain/src/main/assets/welcome.json Outdated Show resolved Hide resolved

nikitamarysolomanpvt added 4 commits October 10, 2019 15:33

nit changes

ceb27a4

nit changes

6b3daed

nit changes

b0fa8b4

nit changes

ce34219

nikitamarysolomanpvt changed the title ~~Fix part of #151: Text input lowfi numeric input interaction view part 2(DO NOT MERGE)~~ Fix part of #151: Text input lowfi numeric input interaction view part 2 Oct 10, 2019

nikitamarysolomanpvt assigned rt4914 Oct 11, 2019

nikitamarysolomanpvt added 2 commits October 11, 2019 11:14

numericInputTypeView test case is in progress

6755d5c

numericInputTypeView test case is in progress

acff28d

rt4914 reviewed Oct 11, 2019

View reviewed changes

rt4914 assigned nikitamarysolomanpvt and unassigned rt4914 Oct 11, 2019

nikitamarysolomanpvt added 4 commits October 11, 2019 11:58

nit changes as per #223

7fb5ea4

nit changes as per #223

ba3be9b

On configuration changes save and restore the text of numericInputType

b474a73

Test Cases for NumericInputInteractionView,

fc60566

Moved test case to StateFragment

nikitamarysolomanpvt assigned veena14cs Oct 12, 2019

nikitamarysolomanpvt requested a review from veena14cs October 12, 2019 11:34

nikitamarysolomanpvt commented Oct 12, 2019

View reviewed changes

nikitamarysolomanpvt requested a review from rt4914 October 12, 2019 11:42

nit changes

966f84d

nikitamarysolomanpvt unassigned rt4914 Oct 17, 2019

nit changes

0b82bbf

BenHenning requested changes Oct 18, 2019

View reviewed changes

BenHenning assigned nikitamarysolomanpvt and unassigned BenHenning Oct 18, 2019

nikitamarysolomanpvt added 4 commits October 18, 2019 14:04

nit

719a4db

NumericInputInteractionView attributes are moved to xml,testcases upd…

dd9163b

…ated as per PR review of Ben, other nit changes

NumericInputInteractionView attributes are moved to xml,testcases upd…

910ec00

…ated as per PR review of Ben, other nit changes

TextInputInteractionView

d20c12e

nikitamarysolomanpvt requested a review from BenHenning October 18, 2019 17:45

nikitamarysolomanpvt assigned BenHenning and unassigned nikitamarysolomanpvt Oct 18, 2019

nikitamarysolomanpvt added 5 commits October 19, 2019 12:41

TextInputInteractionView

2bc3292

nit

61abbe9

nit

38d8e14

nit

9dae69d

nit

1c1e4cb

BenHenning approved these changes Oct 21, 2019

View reviewed changes

BenHenning assigned nikitamarysolomanpvt and unassigned BenHenning Oct 21, 2019

nikitamarysolomanpvt added 5 commits October 21, 2019 14:38

nit

16d4543

nit

fb2c026

nit

d729e43

nit

f27c017

Merge branches 'develop' and 'text-input-lowfi-numeric-input-interact…

13a2013

…ion-view-part-2' of https://github.com/oppia/oppia-android into text-input-lowfi-numeric-input-interaction-view-part-2

nikitamarysolomanpvt merged commit 52f11b6 into develop Oct 21, 2019

rt4914 mentioned this pull request Oct 22, 2019

Fix manifest launcher activity #256

Merged

6 tasks

fsharpasharp mentioned this pull request Dec 9, 2020

Fix #2237: Remove orientation attribute from ConstraintLayout and FrameLayout. #2242

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #151: Lowfi numeric input interaction view part 2 #223

Fix #151: Lowfi numeric input interaction view part 2 #223

nikitamarysolomanpvt commented Oct 10, 2019 •

edited

Loading

rt4914 commented Oct 10, 2019

nikitamarysolomanpvt commented Oct 10, 2019

rt4914 commented Oct 11, 2019

rt4914 left a comment

nikitamarysolomanpvt commented Oct 11, 2019

nikitamarysolomanpvt commented Oct 11, 2019

nikitamarysolomanpvt Oct 12, 2019 •

edited

Loading

BenHenning left a comment

BenHenning Oct 18, 2019

BenHenning Oct 18, 2019

nikitamarysolomanpvt Oct 18, 2019

rt4914 Oct 18, 2019

nikitamarysolomanpvt Oct 18, 2019

BenHenning left a comment

Fix #151: Lowfi numeric input interaction view part 2 #223

Fix #151: Lowfi numeric input interaction view part 2 #223

Conversation

nikitamarysolomanpvt commented Oct 10, 2019 • edited Loading

Explanation

Reference Mock

Reference Design Doc

Checklist

rt4914 commented Oct 10, 2019

nikitamarysolomanpvt commented Oct 10, 2019

rt4914 commented Oct 11, 2019

rt4914 left a comment

Choose a reason for hiding this comment

nikitamarysolomanpvt commented Oct 11, 2019

nikitamarysolomanpvt commented Oct 11, 2019

nikitamarysolomanpvt Oct 12, 2019 • edited Loading

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

BenHenning Oct 18, 2019

Choose a reason for hiding this comment

BenHenning Oct 18, 2019

Choose a reason for hiding this comment

nikitamarysolomanpvt Oct 18, 2019

Choose a reason for hiding this comment

rt4914 Oct 18, 2019

Choose a reason for hiding this comment

nikitamarysolomanpvt Oct 18, 2019

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

nikitamarysolomanpvt commented Oct 10, 2019 •

edited

Loading

nikitamarysolomanpvt Oct 12, 2019 •

edited

Loading