Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Structure: FractionsInteractionView [Blocked: #150] #155

Closed
BenHenning opened this issue Sep 20, 2019 · 2 comments
Closed

UI Structure: FractionsInteractionView [Blocked: #150] #155

BenHenning opened this issue Sep 20, 2019 · 2 comments
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

This is tracking implementing the initial UI structure of the fractions interaction being fully implemented in #33.

@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #118 for interaction with the domain layer, and #150 for the initial interaction UI structure.

@BenHenning BenHenning changed the title UI Structure: FractionsInteractionView [Blocked: #150, #118] UI Structure: FractionsInteractionView [Blocked: #150] Sep 30, 2019
nikitamarysolomanpvt added a commit that referenced this issue Oct 23, 2019
…View low-fi (#246)

* NumberInputInteractionView dynamically created on state interaction id NumericInput from dummy data welcome.json ,welcome.json file "init_state_name"modified to "Numeric input",

* NumberInputInteractionView dynamically created on state interaction id NumericInput from dummy data welcome.json

* added fetch button, and fetch textview to fetch the data from dynamic numbertextinputlayout onbutton click. on button click listner implemented

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* numericInputTypeView test case is in progress

* numericInputTypeView test case is in progress

* nit changes as per #223

* nit changes as per #223

* On configuration changes save and restore the text of numericInputType

* Test Cases for NumericInputInteractionView,
Moved test case to StateFragment

* Test Cases for NumericInputInteractionView,
Moved test case to StateFragment,PR suggestions updated

* PR suggestions updated

* PR suggestions updated

* Merge branch 'develop' of https://github.com/oppia/oppia-android into topic-player-multiple-tabs

# Conflicts:
#	app/build.gradle
#	app/src/main/AndroidManifest.xml
#	app/src/main/res/values/styles.xml

* nit changes as per PR review

* nit changes as per PR review

* nit changes as per PR review

* nit changes as per PR review

* Number input test Activity test cases

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* setReal type in getPendingAnswer

* updated test cases, disabled long click to prevent pasting value

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* nit changes

* NumericInputInteractionViewTestActivity renamed to InputInteractionViewTestActivity and test case updated

* nit changes

* nit changes

* nit changes

* nit

* NumericInputInteractionView attributes are moved to xml,testcases updated as per PR review of Ben, other nit changes

* NumericInputInteractionView attributes are moved to xml,testcases updated as per PR review of Ben, other nit changes

* TextInputInteractionView

* TextInputInteractionView

* test cases

* nit

* nit

* nit

* nit

* nit

* Merge branches 'develop' and 'lowfi-input-interaction-views' of https://github.com/oppia/oppia-android into lowfi-input-interaction-views

# Conflicts:
#	app/src/main/java/org/oppia/app/activity/InputInteractionViewTestActivity.kt
#	app/src/main/java/org/oppia/app/customview/interaction/NumericInputInteractionView.kt
#	app/src/main/res/layout/activity_numeric_input_interaction_view_test.xml
#	app/src/main/res/values/dimens.xml
#	app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt

* nit

* nit

* nit

* nit

* Merge branches 'develop' and 'text-input-lowfi-numeric-input-interaction-view-part-2' of https://github.com/oppia/oppia-android into text-input-lowfi-numeric-input-interaction-view-part-2

# Conflicts:
#	app/src/sharedTest/java/org/oppia/app/activity/InputInteractionViewTestActivityTest.kt

* nit

* NumberWithUnitsInputInteractionView

* nit

* nit

* NumberWithUnitsInputInteractionView

* moved InputInteractionViewTestActivityTest to testing folder
@BenHenning
Copy link
Member Author

Looks like this wasn't auto-closed, but it should be done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

2 participants