Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full UI: FractionsInteractionView [Blocked: #15, #155] #33

Closed
2 tasks
BenHenning opened this issue Aug 2, 2019 · 2 comments
Closed
2 tasks

Full UI: FractionsInteractionView [Blocked: #15, #155] #33

BenHenning opened this issue Aug 2, 2019 · 2 comments
Assignees
@nikitamarysolomanpvt
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.3 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019 •
edited by rt4914
Loading

This is tracking implementing the fully polished UI version of the fractions interaction.

See the web frontend for details on how the fractions interaction works.

Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/40d6cf5f-f673-42c8-af15-035f711ef6b9/PM-IN-Introduction-

Checklist

  • FractionInput (similar to this mock)

Screenshot 2019-11-08 at 3 50 56 PM

  • Final touch up with padding, margin, animations and Accessibility Scanner test
@BenHenning BenHenning added Where: Skills/Questions Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked on #28 to introduce the general interaction architecture.

@BenHenning BenHenning mentioned this issue Aug 2, 2019
Open
@BenHenning BenHenning changed the title Fractions input Fractions input [Blocked: #28] Aug 12, 2019
@BenHenning BenHenning mentioned this issue Sep 20, 2019
Closed
@BenHenning BenHenning changed the title Fractions input [Blocked: #28] Full UI: FractionsInteractionView [Blocked: #15, #155] Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #15 for a full domain controller implementation and #155 for the initial structure introduction for this interaction.

@BenHenning BenHenning mentioned this issue Sep 20, 2019
Merged
6 tasks
@BenHenning BenHenning mentioned this issue Oct 22, 2019
Merged
6 tasks
nikitamarysolomanpvt added a commit that referenced this issue Nov 14, 2019
@nikitamarysolomanpvt
Fix part of #28,#29,#33: Hi-fi input interaction views (#330)
0473566 
* nit

* UI hi-fi for text,number,and fraction input views

* UI hi-fi for text,number,and fraction input views

* UI hi-fi for text,number,and fraction input views nit

* nit

* nit

* test cases update

* accent color

* input type in fraction input type

* input type in fraction input type

* Merge branches 'develop' and 'hi-fi-input-interaction-views' of https://github.com/oppia/oppia-android into hi-fi-input-interaction-views

# Conflicts:
#	app/src/main/res/layout/text_input_interaction_item.xml

* text color in input type views

* changed inputtype in edit text
nikitamarysolomanpvt added a commit that referenced this issue Nov 14, 2019
@nikitamarysolomanpvt
Fix part of #28,#29,#33: Hi fi input interaction views margin updated (…
dcf3f22 
…#344)

* nit

* UI hi-fi for text,number,and fraction input views

* UI hi-fi for text,number,and fraction input views

* UI hi-fi for text,number,and fraction input views nit

* nit

* nit

* test cases update

* accent color

* input type in fraction input type

* input type in fraction input type

* Merge branches 'develop' and 'hi-fi-input-interaction-views' of https://github.com/oppia/oppia-android into hi-fi-input-interaction-views

# Conflicts:
#	app/src/main/res/layout/text_input_interaction_item.xml

* text color in input type views

* changed inputtype in edit text

* margin updated in input views
Merged
10 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.3 Release Blockers (Prototype MR3) ...
Development

No branches or pull requests
2 participants
@BenHenning @nikitamarysolomanpvt