Fix #380: Hi fi input interaction views #405

nikitamarysolomanpvt · 2019-11-18T09:15:22Z

Explanation

Whenever state is changed the scroll view should start from the top everytime.For this removed the focus from edittext.

Checklist

Whenever state is changed the scroll view should start from the top everytime.
On click of input type interaction item, it requires two clicks to display keyboard, which should actually be just a single click.

Reference Mocks

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/4d4e4bd8-3755-41fc-bf83-3dcff5d5eee1/Lesson-1-a-ii-Exploration-Player-Text-Input-No-Ans
https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/eeed0f6c-54ca-4371-ab23-5199abd87f28/Lesson-1-a-ii-Exploration-Player-Text-Input-Keyboa
https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/d66097bf-8421-41d8-bfda-2450d6e98dea/Lesson-1-a-i-Exploration-Player-Fraction-Input-No-
https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/249c3349-605b-4569-bbe9-1a017ab90101/Lesson-1-a-i-Exploration-Player-Fraction-Input-No-
https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/c4b0dfb3-53b4-491e-a759-818e096183fd/Lesson-1-a-v-Exploration-Player-Numeric-Input-No-A

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

…://github.com/oppia/oppia-android into hi-fi-input-interaction-views # Conflicts: # app/src/main/res/layout/text_input_interaction_item.xml

… hi-fi-input-interaction-views

On click of input type interaction item, it requires two clicks to display keyboard, which should actually be just a single click. thus preventing scroll due to edit text focus

rt4914

Currently, there is one case in which the new state does not start from the top-position:

add this line
binding.stateRecyclerView.smoothScrollToPosition(0)

at the end of StateFragmentPresenter -> processEphemeralStateResult function.

nikitamarysolomanpvt · 2019-11-18T10:17:18Z

Currently, there is one case in which the new state does not start from the top-position:

add this line
binding.stateRecyclerView.smoothScrollToPosition(0)

at the end of StateFragmentPresenter -> processEphemeralStateResult function.

I fixed input view focus issue because of which the scroll was happening.
as per your suggestion added binding.stateRecyclerView.smoothScrollToPosition(0) in processEphemeralStateResult

…ToPosition(0) in processEphemeralStateResult

rt4914

LGTM

BenHenning

Generally LGTM--thanks @nikitamarysolomanpvt! I had some comments that should definitely be addressed, but the solution seems sensible based on my understanding of focus behavior on Android. Also, I tried it out locally and it seems to work quite well.

gradle/wrapper/gradle-wrapper.properties

app/src/main/java/org/oppia/app/customview/interaction/FractionInputInteractionView.kt

app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt

app/src/main/java/org/oppia/app/utility/KeyboardHelper.kt

mschanteltc · 2019-11-19T06:43:02Z

@mschanteltc as per your reply in mail Fix #28,#29,#33: Hi-fi input interaction views #330

I agree that when the input is in focus, the keyboard would appear. However if the user taps on the screen that is not the input bar or the keyboard, the keyboard should collapse. If the input is still empty, then it would still show placeholder text. Otherwise if the input has characters in it, those characters remain in the bar and the placeholder text is not seen.

Please find the your suggestions implemented in this PR.

Thanks Nikita! Is it possible you can attach an image/gif so I can see how this works please?

rt4914 · 2019-11-19T09:30:43Z

@nikitamarysolomanpvt This PR looks good to me including Ben's suggestions. Just reply to this comment and Chantel's comment.

rt4914

LGTM.

nikitamarysolomanpvt · 2019-11-19T09:45:01Z

@mschanteltc

@mschanteltc as per your reply in mail Fix #28,#29,#33: Hi-fi input interaction views #330

I agree that when the input is in focus, the keyboard would appear. However if the user taps on the screen that is not the input bar or the keyboard, the keyboard should collapse. If the input is still empty, then it would still show placeholder text. Otherwise if the input has characters in it, those characters remain in the bar and the placeholder text is not seen.

Please find the your suggestions implemented in this PR.

Thanks Nikita! Is it possible you can attach an image/gif so I can see how this works please?

nikitamarysolomanpvt · 2019-11-19T09:46:37Z

@nikitamarysolomanpvt This PR looks good to me including Ben's suggestions. Just reply to this comment and Chantel's comment.

Done

…://github.com/oppia/oppia-android into hi-fi-input-interaction-views

mschanteltc · 2019-11-21T18:42:17Z

When the input is empty, can we make the "Submit" button disabled? Also can we make the blue boxes' bottom be the same height as the blue boxes' top padding?

Otherwise the functionality of the text input LGTM!

nikitamarysolomanpvt added 20 commits November 11, 2019 15:56

nit

acf2610

UI hi-fi for text,number,and fraction input views

b760c44

UI hi-fi for text,number,and fraction input views

deaa102

UI hi-fi for text,number,and fraction input views nit

5f30564

nit

8484f34

nit

33e1232

test cases update

d108ff0

accent color

fc2355f

input type in fraction input type

adc0fbf

input type in fraction input type

e0a7c5a

Merge branches 'develop' and 'hi-fi-input-interaction-views' of https…

47b7aad

…://github.com/oppia/oppia-android into hi-fi-input-interaction-views # Conflicts: # app/src/main/res/layout/text_input_interaction_item.xml

Merge branches 'develop' and 'hi-fi-input-interaction-views' of https…

1e3ed3a

…://github.com/oppia/oppia-android into hi-fi-input-interaction-views # Conflicts: # app/src/main/res/layout/text_input_interaction_item.xml

text color in input type views

fe0f1d8

changed inputtype in edit text

8a489a0

margin updated in input views

0eff2ef

margin updated in input views

9d8f704

nit

b429ec8

keyboardhelper to handle softinoutkeyboard

9981d81

Merge branch 'develop' of https://github.com/oppia/oppia-android into…

321facd

… hi-fi-input-interaction-views

Edit text focus removed.

ef864b2

On click of input type interaction item, it requires two clicks to display keyboard, which should actually be just a single click. thus preventing scroll due to edit text focus

nikitamarysolomanpvt requested review from veena14cs and rt4914 November 18, 2019 09:17

nikitamarysolomanpvt assigned rt4914, veena14cs and mschanteltc Nov 18, 2019

rt4914 suggested changes Nov 18, 2019

View reviewed changes

rt4914 assigned nikitamarysolomanpvt and unassigned rt4914 Nov 18, 2019

as per review suggestion added binding.stateRecyclerView.smoothScroll…

70d4c73

…ToPosition(0) in processEphemeralStateResult

nikitamarysolomanpvt removed their assignment Nov 18, 2019

rt4914 approved these changes Nov 18, 2019

View reviewed changes

rt4914 assigned nikitamarysolomanpvt and unassigned rt4914 Nov 18, 2019

BenHenning self-assigned this Nov 18, 2019

nit

1c94120

BenHenning approved these changes Nov 19, 2019

View reviewed changes

BenHenning removed their assignment Nov 19, 2019

merged with develop, inputviews test cases fix

8e88592

nikitamarysolomanpvt added 3 commits November 19, 2019 12:48

kdoc for keyboardhelper.nit changes

f9f5149

kdoc for keyboardhelper

7922ce3

nit

c288193

nikitamarysolomanpvt assigned rt4914 and unassigned nikitamarysolomanpvt Nov 19, 2019

nit

16ed76d

rt4914 approved these changes Nov 19, 2019

View reviewed changes

rt4914 assigned nikitamarysolomanpvt and unassigned rt4914 Nov 19, 2019

nikitamarysolomanpvt removed their assignment Nov 19, 2019

nikitamarysolomanpvt added 3 commits November 19, 2019 15:17

Merge branches 'develop' and 'hi-fi-input-interaction-views' of https…

03ddc53

…://github.com/oppia/oppia-android into hi-fi-input-interaction-views

nit

9984a6d

nit

fbfb1c0

nikitamarysolomanpvt merged commit 7704741 into develop Nov 19, 2019

mschanteltc assigned nikitamarysolomanpvt and unassigned mschanteltc Nov 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #380: Hi fi input interaction views #405

Fix #380: Hi fi input interaction views #405

nikitamarysolomanpvt commented Nov 18, 2019 •

edited

Loading

rt4914 left a comment

nikitamarysolomanpvt commented Nov 18, 2019

rt4914 left a comment

BenHenning left a comment

mschanteltc commented Nov 19, 2019

rt4914 commented Nov 19, 2019

rt4914 left a comment

nikitamarysolomanpvt commented Nov 19, 2019 •

edited

Loading

nikitamarysolomanpvt commented Nov 19, 2019

mschanteltc commented Nov 21, 2019

Fix #380: Hi fi input interaction views #405

Fix #380: Hi fi input interaction views #405

Conversation

nikitamarysolomanpvt commented Nov 18, 2019 • edited Loading

Explanation

Checklist

Reference Mocks

Checklist

rt4914 left a comment

Choose a reason for hiding this comment

nikitamarysolomanpvt commented Nov 18, 2019

rt4914 left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

mschanteltc commented Nov 19, 2019

rt4914 commented Nov 19, 2019

rt4914 left a comment

Choose a reason for hiding this comment

nikitamarysolomanpvt commented Nov 19, 2019 • edited Loading

nikitamarysolomanpvt commented Nov 19, 2019

mschanteltc commented Nov 21, 2019

nikitamarysolomanpvt commented Nov 18, 2019 •

edited

Loading

nikitamarysolomanpvt commented Nov 19, 2019 •

edited

Loading