Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Structure: MultipleChoiceInteractionView [Blocked: #150] #153

Closed
BenHenning opened this issue Sep 20, 2019 · 1 comment · Fixed by #276
Closed

UI Structure: MultipleChoiceInteractionView [Blocked: #150] #153

BenHenning opened this issue Sep 20, 2019 · 1 comment · Fixed by #276
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

This is tracking implementing the initial UI structure of the multiple choice interaction being fully implemented in #31.

@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #118 for interaction with the domain layer, and #150 for the initial interaction UI structure.

@BenHenning BenHenning changed the title UI Structure: MultipleChoiceInteractionView [Blocked: #150, #118] UI Structure: MultipleChoiceInteractionView [Blocked: #150] Sep 30, 2019
veena14cs added a commit that referenced this issue Nov 5, 2019
* Introduce first pass interface for ExplorationProgressController.

* Fill in the stubbed logic for ExplorationProgressController. Still no
tests to verify correctness.

Also, added a method to facilitate notifying of DataProvider changes on
the UI thread.

* Fix lateinit issue in ExplorationProgressController due to wrongly ordered
initialization.

* Fix a variaty of issues in the exp progress controller, properly hook it up to
the data controller, and start adding tests.

* Created a separate ExplorationRetriever, hooked up
AnswerClassificationController, and attempted to make
ExplorationProgressController thread-safe.

The thread-safety led to significant interface changes in the progress
controller, and led to discovering some issues with the mediator live data
approach to interop coroutines and LiveData. This locking mechanism will
need to change since the optimal solution requires resolving #90.

* Change the locking mechanism for ExplorationProgressController to work
with the current MediatorLiveData implementation (see #90 for more
context). Fix existing progress controller tests and add a few more. All
current progress controller tests are passing.

* Finish tests for ExplorationProgressController and add test classification
support for the second test exploration (about_oppia).

* craeted image parser

* ObservableViewModel

* Load exploration and open ExplorationActivity

* Test case for load exploration

* fetch exploration

* Connection with StateFragment

* update

* update

* working on fetching customization_args

* Update StateFragmentPresenter.kt

* Separated this in its own PR

* Delete UrlImageParser.kt

Separated this in its own PR.

* Update StateFragmentPresenter.kt

* Update build.gradle

* Create HtmlParser.kt

* Update HtmlParser.kt

* Update HtmlParser.kt

* Update HtmlParser.kt

* working on testcases

* Update HtmlParserTestActivty.kt

* Update HtmlParserTestActivty.kt

* added testcases.

* Update AndroidManifest.xml

* Update InteractionAdapter.kt

* Update InteractionAdapter.kt

* Update HtmlParser.kt

* corrected variable names.

* updated variables.

* Update HtmlParser.kt

* Update HtmlParser.kt

* Update HtmlParserTestActivty.kt

* Update HtmlParser.kt

* Delete InteractionAdapter.kt

* deteted unused xml files

* merged html code.

* Update HtmlParser.kt

* Delete UrlImageParserTest.kt

* used dagger injection for UrlImageParser.

* Update HtmlParserTestActivty.kt

* Update HtmlParserTestActivty.kt

* Update HtmlParser.kt

* Update HtmlParserTestActivty.kt

* updated tests

* updated test

* moved to testing package

* Update HtmlParserTestActivty.kt

* Update HtmlParserTestActivty.kt

* fix issues

* fix issues.

* fixed issues

* fixed issues.

* Update activity_test_html_parser.xml

* fixes

* Update HtmlParserTest.kt

* Update HtmlParserTest.kt

* fixed issues.

* fixing issues.

* made use of factory

* Update HtmlParserTest.kt

* Update UrlImageParser.kt

* Update AndroidManifest.xml

* Update HtmlParserTestActivity.kt

* nit

* Update AudioFragmentTest.kt

* updated

* fixes

* Update UrlImageParser.kt

* Not used in this.

* fixes

* Not used.

* Update CellularDataDialogFragmentTest.kt

* reverted

* Update CellularDataDialogFragmentTest.kt

* fixes

* Update ImageLoader.kt

* Update HtmlParser.kt

* Update HtmlParser.kt

* Update build.gradle

* fixed issues.

* Update UrlImageParser.kt

* Update UrlImageParser.kt

* Update UrlImageParser.kt

* Update ImageParsingAnnotations.kt

* working on image loader

* Injected ImageLoader

* updated image loader.

* Update ActivityComponent.kt

* Update HtmlParserTestActivity.kt

* Update GlideImageLoader.kt

* removed annotation

* Update HtmlParser.kt

* line break

* fix

* fix comments

* Update UrlImageParser.kt

* Update UrlImageParser.kt

* injected context

* working on testcase.

* testcase added

* added test case

* testcases

* Update build.gradle

* Update AndroidManifest.xml

* fixes

* Update UrlImageParserTest.kt

* changed to CutomTarget

* Update UrlImageParserTest.kt

* updated.

* Update UrlImageParserTest.kt

* Update HtmlParserTestActivity.kt

* Update misc.xml

* Update GlideImageLoaderModule.kt

* updated with image parser

* updated

* Update StateRetriever.kt

* Create StateSelectionInteractionTest.kt

* Configuration change save state

* Update StateSelectionInteractionTest.kt

* Update StateSelectionInteractionTest.kt

* Update StateSelectionInteractionTest.kt

* Update StateFragmentContentCardTest.kt

* Update HtmlParserTest.kt

* deleted test class for loading image and added todo

* updated

* Update build.gradle

* Update GlideImageLoader.kt

* Update build.gradle

* Update UrlImageParser.kt

* updated.

* update

* update

* Update StateFragmentPresenter.kt

* ContentCardTestActivity introduced

* updated test.

* Update AndroidManifest.xml

* Update AndroidManifest.xml

* Update StateFragmentContentCardTest.kt

* Changed test activity.

* renamed file.

* Update state_fragment.xml

* moved test case to stateFragmentTest

* working on test

* changes in activity.

* Update StateFragmentTest.kt

*  changes.

* Update content_item.xml

* Update ContentViewModel.kt

* Update StateFragmentTest.kt

* updated tests.

* Update HomeFragmentPresenter.kt

* Update SelectionInteractionCustomizationArgsViewModel.kt

* Update home_fragment.xml

* Update build.gradle

* Update state_fragment.xml

* Update StateFragmentTest.kt

* KDoc added

* Test cases optimised

* nit change

* Update StateFragmentTest.kt

* Update ItemClickListener.kt

* Update StateRetriever.kt

* Update ExplorationRetriever.kt

* Update ExplorationRetriever.kt

* fixed issues.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment