Fix #153/#154 : MultipleChoice/ItemSelection Interaction #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
veena14cs
changed the base branch from
sample-exploration-player
to
merge-fix
veena14cs
commented
Oct 25, 2019
| @@ -52,6 +53,7 @@ class HomeFragmentPresenter @Inject constructor( | |||
| } | |||
|
|
|||
| fun playExplorationButton(v: View) { | |||
| explorationDataController.stopPlayingExploration() | |||
There was a problem hiding this comment.
stopPlayingExploration() is added to test with different exploration.
veena14cs
commented
Oct 25, 2019
| @@ -30,7 +31,7 @@ class ExplorationRetriever @Inject constructor(private val context: Context) { | |||
| internal suspend fun loadExploration(explorationId: String): Exploration { | |||
| return when (explorationId) { | |||
| TEST_EXPLORATION_ID_5 -> loadExplorationFromAsset("welcome.json") | |||
| TEST_EXPLORATION_ID_6 -> loadExplorationFromAsset("about_oppia.json") | |||
| TEST_EXPLORATION_ID_6 -> loadExplorationFromAsset("oppia_exploration.json") | |||
There was a problem hiding this comment.
Added new exploration for testing ItemSelectionInput Interaction.
This was referenced Oct 26, 2019
|
Duplicate of this PR is created #276 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR is based on content-card #245 , as it contains Html parser implementation and it is used in MultipleChoice/ItemSelection Input interaction.
This PR is duplicate of #225. It contains UI structure for Multiple choice and item selection interactions, and fixes #153 and #154.
Reference Design Doc: https://docs.google.com/document/d/1HFwDFcqenAXepbYr5rfawGHvkeBZpYvNMs228AWLn24/edit?usp=sharing