Fix #153/#154 : MultipleChoice/ItemSelection Interaction View #188 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests to verify correctness. Also, added a method to facilitate notifying of DataProvider changes on the UI thread.
…dered initialization.
… it up to the data controller, and start adding tests.
Conflicts: domain/build.gradle domain/src/main/java/org/oppia/domain/exploration/ExplorationDataController.kt Also, migrate the data controller to the retriever.
veena14cs
requested review from
rt4914,
BenHenning and
nikitamarysolomanpvt
rt4914
reviewed
Sep 30, 2019
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/exploration/ExplorationActivityPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
AnswerClassificationController, and attempted to make ExplorationProgressController thread-safe. The thread-safety led to significant interface changes in the progress controller, and led to discovering some issues with the mediator live data approach to interop coroutines and LiveData. This locking mechanism will need to change since the optimal solution requires resolving #90.
BenHenning
requested changes
Oct 1, 2019
There was a problem hiding this comment.
Thanks @veena14cs! I had some high-level feedback. Please let me know if you'd like to discuss any of this in more detail.
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentPresenterTest.kt
Outdated
Show resolved
Hide resolved
…tion-player-3-content-interaction
6 tasks
veena14cs
changed the base branch from
develop
to
introduce-load-exploration-part-1
veena14cs
changed the base branch from
introduce-load-exploration-part-1
to
develop
2 tasks
|
Duplicate of this PR is been created #225 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is duplicate of #188. It contains UI structure for Multiple choice and item selection interactions, and fixes #153 and #154.
Reference Design Doc: https://docs.google.com/document/d/1HFwDFcqenAXepbYr5rfawGHvkeBZpYvNMs228AWLn24/edit?usp=sharing