Fix part of #161 : Introduce html parser #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests to verify correctness. Also, added a method to facilitate notifying of DataProvider changes on the UI thread.
…dered initialization.
… it up to the data controller, and start adding tests.
Conflicts: domain/build.gradle domain/src/main/java/org/oppia/domain/exploration/ExplorationDataController.kt Also, migrate the data controller to the retriever.
AnswerClassificationController, and attempted to make ExplorationProgressController thread-safe. The thread-safety led to significant interface changes in the progress controller, and led to discovering some issues with the mediator live data approach to interop coroutines and LiveData. This locking mechanism will need to change since the optimal solution requires resolving #90.
with the current MediatorLiveData implementation (see #90 for more context). Fix existing progress controller tests and add a few more. All current progress controller tests are passing.
…ation support for the second test exploration (about_oppia).
…-controller' into introduce-load-exploration-part-1
…yer-content-interaction
Separated this in its own PR.
veena14cs
changed the base branch from
develop
to
exploration-player-content-interaction
app/src/sharedTest/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
rt4914
approved these changes
Oct 17, 2019
BenHenning
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Thanks @veena14cs. I had some confusion about the test logic itself, but the overall approach LGTM. Feel free to submit once my comments are addressed, or re-assign to me if you'd like me to do one more pass.
app/src/main/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/activity/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
BenHenning
requested changes
Oct 18, 2019
There was a problem hiding this comment.
Thanks @veena14cs--there appear to be a few test files here that are being fully commented out. I understand that's needed to unblock running them locally, but please don't check them in like that.
Also, I think there are some unresolved comment threads that I left earlier regarding the need for the requestedOrientation bits. Please address those comments.
app/src/sharedTest/java/org/oppia/app/player/audio/AudioFragmentTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/audio/CellularDataDialogFragmentTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/testing/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/testing/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/testing/HtmlParserTestActivty.kt
Outdated
Show resolved
Hide resolved
|
Dagger implementation of this is done in PR #205 , hence closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR supports rich-text. It processes Oppia's custom HTML tags and displays the styled text in the textview.
Note: It doesn't support latex.
Reference Design Doc:
https://docs.google.com/document/d/1Knx8KIPN7Amqav2wu-jvSKd5RjolS-taqRF3eUNSDu8/edit?usp=sharing