Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final UI: Introduce topic list on home screen [Blocked: #9, #134] #10

Closed
2 of 10 tasks
BenHenning opened this issue Aug 2, 2019 · 9 comments
Closed
2 of 10 tasks

Final UI: Introduce topic list on home screen [Blocked: #9, #134] #10

BenHenning opened this issue Aug 2, 2019 · 9 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 2, 2019 •
edited by rt4914
Loading

The Oppia home screen should follow the requirements listed in the Oppia PRD. It should have access to the navigation drawer, and be accessible from the splash screen if there is already a logged in profile. The home screen should be able to navigate directly to topics, stories, and skill training pages. It should be navigable back from each of those if the user uses the system back button.

Mock Link: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/d47aa8de-a7a8-4d25-b011-5baefc7b7098/HP-Home-Page-

Checklist

  • Home Toolbar, also suggestion: do not add "search" icon in this because there is no functionality for search currently.

Screenshot 2019-11-07 at 3 05 41 PM

  • Welcome message to learner (check comments before taking this task)

Screenshot 2019-11-07 at 3 07 28 PM

  • Recently-played and View All text

Screenshot 2019-11-07 at 3 07 34 PM

  • Promoted Story Item (In this mocks are representing a list of promoted stories but for now in development we are keeping only one promoted story at a time) (Also, do not implement "Download" status UI)

Screenshot 2019-11-07 at 3 07 39 PM

Screenshot 2019-11-07 at 3 07 47 PM

Screenshot 2019-11-07 at 3 07 57 PM

Screenshot 2019-11-07 at 3 08 05 PM
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Proof of concept milestone Aug 2, 2019
@BenHenning
Copy link
Member Author

This is blocked on #9.

@BenHenning
Copy link
Member Author

Note that the profile part of the navigation description above will be the eventual behavior, but not the implemented behavior in the proof of concept.

This was referenced Aug 2, 2019
Closed
Open
@BenHenning BenHenning changed the title Introduce home screen Introduce home screen [Blocked: #9] Aug 12, 2019
@BenHenning BenHenning self-assigned this Aug 23, 2019
@BenHenning BenHenning changed the title Introduce home screen [Blocked: #9] Final UI: Introduce topic list on home screen [Blocked: #9] Sep 19, 2019
@BenHenning BenHenning mentioned this issue Sep 19, 2019
Closed
2 tasks
@BenHenning BenHenning changed the title Final UI: Introduce topic list on home screen [Blocked: #9] Final UI: Introduce topic list on home screen [Blocked: #9, #174] Sep 19, 2019
@BenHenning
Copy link
Member Author

This is also blocked on #134.

@BenHenning BenHenning changed the title Final UI: Introduce topic list on home screen [Blocked: #9, #174] Final UI: Introduce topic list on home screen [Blocked: #9, #134] Sep 19, 2019
@BenHenning BenHenning modified the milestones: Proof of concept, Prototype -- UI (high fidelity) Sep 20, 2019
@BenHenning BenHenning removed their assignment Sep 20, 2019
@BenHenning BenHenning mentioned this issue Sep 22, 2019
Merged
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Oct 20, 2019
@rt4914
Copy link
Contributor

rt4914 commented Nov 7, 2019

@BenHenning @seanlip for now how do we implement the Welcome message, because that needs a user-name from Profile.

@seanlip
Copy link
Member

seanlip commented Nov 7, 2019

I would have thought it'd be possible to access the "current user name" for the user? I'll need to defer to @BenHenning on the technical details, though.

@veena14cs
Copy link
Contributor

veena14cs commented Nov 8, 2019 •
edited
Loading

@rt4914 I will take up Topic Summary Item and Topic Summary Item list tasks.

veena14cs added a commit that referenced this issue Nov 11, 2019
@veena14cs
Fix part #10: Final UI All topics text (#315)
b0edee8 
* Update all_topics.xml

* Update all_topics.xml
@veena14cs
Copy link
Contributor

@rt4914 I will be taking entire task from this UI to avoid confusion between margins from parent and child views.

rt4914 added a commit that referenced this issue Nov 12, 2019
@rt4914
Fix part of #10: Hifi continue playing (#332)
8d13627 
* Toolbar introduced

* Final implementation

* Nit changes

* Manifest nit changes
veena14cs added a commit that referenced this issue Nov 12, 2019
@veena14cs
Fix part #10: HiFi topic list on home screen (#319)
1da1a22 
* working on topic summary UI

* Update home_fragment.xml

* fixed nit

* Update topic_summary_view.xml

* Update topic_summary_view.xml

* updated changes

* added white background drawable

* updated changes

* Update promoted_story_card.xml

* Update home_fragment.xml

* Fixed nit.

* Update topic_summary_view.xml
@rt4914
Copy link
Contributor

rt4914 commented Jan 16, 2020

Assigning the UI of ContinuePlayingList to @Luffy18346

@Luffy18346 Luffy18346 mentioned this issue Jan 16, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Jan 17, 2020
@Luffy18346 @rt4914
Fix part of #10: Hifi ContinuePlaying (#605)
7570940 
* Removed padding from sides in Image in ongoing_story_card in ContinuePlayingList.

* Reapplied side padding to the image. Removed hardcoded height attribute and applied dimensionRatio to the image.

* ContentDescription attribute and the string reference for it is added in ongoing_story_card.

* ScaleType of ImageView is changed and side paddings are removed, RecyclerView paddingBottom set to 172dp

* Removed padding top from the image in ongoing_story_card.
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. and removed Workstream: Highfi UI Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jun 23, 2020
@BenHenning BenHenning removed their assignment Jun 23, 2020
@rt4914
Copy link
Contributor

rt4914 commented Jun 24, 2020

This PR has been finished via multiple small PRs #315 #319 #538 #954

@rt4914 rt4914 closed this as completed Jun 24, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

No branches or pull requests
4 participants
@rt4914 @seanlip @BenHenning @veena14cs